Repository navigation
test(diagrams): pin exact SVG fixture output (FU-1015) - #1833
Conversation
Pin the existing light-theme fixture output with an independent literal.\nCover the exact crop, metadata, paint, geometry and text whitespace while\nretaining the existing focused assertions. No-Test: Test-only missing coverage for already-correct export; baseline and candidate fixture tests pass, so no artificial bug RED. Co-Authored-By: GPT-6.1 <noreply@openai.com>
Cuarroc
added
the
review-ok
|
Root acceptance (tier C, test-only: docs/diagrams/export-svg.test.mjs +10/-0): diff read, independent literal expected SVG through the public CLI; prepush 0 and ls-remote match per report, own ls-remote 12:23Z = efd6c03. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efd6c03aeb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| + '<tspan style="fill:#000000;font-family:Geist, Inter, -apple-system, BlinkMacSystemFont, \'Segoe UI\', sans-serif;font-size:16px;font-weight:400;text-anchor:start">Hello</tspan> ' | ||
| + '<tspan style="fill:#000000;font-family:Geist, Inter, -apple-system, BlinkMacSystemFont, \'Segoe UI\', sans-serif;font-size:16px;font-weight:400;text-anchor:start">World</tspan>' | ||
| + '</text></g></svg>'; | ||
| assert.equal(svg, expected); |
There was a problem hiding this comment.
This assertion completes the R1581-K3 follow-up, but at the reviewed head docs/PLAN.md:365 still describes all FU-1015 items as “Geplant: nicht disponiert” and does not record this dispatched, implemented package. Update or split that row in this change so the canonical plan states the post-merge status rather than deliberately leaving reconciliation to Root afterward.
AGENTS.md reference: AGENTS.md:L139-L139
Useful? React with 👍 / 👎.
|
@Mergifyio queue |
☑️ This pull request is already queued |
Merge Queue Status
This pull request spent 35 minutes 47 seconds in the queue, including 35 minutes 15 seconds running CI. Required conditions to merge
|
Der Test prüft jetzt die vollständige SVG-Ausgabe der vorhandenen kleinen Vorlage. Dadurch fallen auch Änderungen auf, die die bisherigen Einzelprüfungen nicht erkennen. Für dich ist nichts zu tun; Prüfung und Abnahme folgen durch die Koordination.
Report
Plan-ID: FU-1015
Package: FU-1015 / R1581-K3 (parent PR #1581) · Review tier: C, test-only.
Goal / benefit: Close the missing exact-output coverage with an independent literal expected SVG, exercised through the exporter's public CLI.
Parent / ticket / owner: FU-1015; ticket
2c8ddf2f-60fe-414c-b6e0-6d038a04ba5f; job86 / srv-fu1015-svg-exact. Root owns acceptance and subsequent integration.Base:
88c10c7716ad2dca629930adbcd8a291baf5d858· Head:efd6c03aeb352303c823283af3f1fe5d7834a5a3· Branch:codex/fu1015-svg-exact· Raw diff: 10 added, 0 deleted lines, one file.What changed
Extend the existing light-theme fixture test in
docs/diagrams/export-svg.test.mjswith complete string equality. The literal pins the 12/12/176/116 crop, accessibility metadata, background, node geometry and paint, inline text styles, tspan whitespace and serialization. The expected string is written literally from the small fixture and its contract; it is not calculated by the exporter or strip helper. The existing focused assertions remain intact. No exporter, strip implementation, renderer, fixture, diagram, snapshot, dependency or CI file changes.No-Test rationale: This is missing test coverage for already-correct behavior. The existing fixture suite passed before and after the assertion; no product bug or artificial failing test is claimed. The commit carries a justified
No-Test:trailer.Evidence
Observed on 2026-10-22 in this branch's own worktree; all post-commit checks bind to the head above.
npm run dev:start-check -- --max-cargo 4 --min-free-gb 3.5node --test docs/diagrams/export-svg.test.mjsbash scripts/ci/secret-scan.shgit commitwith normal hooksbash scripts/ci/red-first.shbash scripts/ci/gates.sh lane prepushgit push -u origin codex/fu1015-svg-exactgit ls-remote origin codex/fu1015-svg-exactefd6c03aeb352303c823283af3f1fe5d7834a5a3git diff --check 88c10c7716ad2dca629930adbcd8a291baf5d858 HEADNative evidence: Own
get_goalreturned no goal, thencreate_goalcreated the bounded ticket goal; subsequentget_goalconfirmed it active. The worker goal ends at checked draft handover, not parent acceptance. Actual sessionturn_contextreportedgpt-6.1-sol, efforthigh, provideropenai; subscription authentication was observed. Exact process/session/admission evidence stays in the private worker handover.Source coverage: Read the fixture, exporter and strip helper directly. No native graph or AgentsRoom memory tool was available, and the local
lage-jetztmirror was absent; no graph-completeness claim. Live PR/branch checks were used.NICHT ABGEDECKT
#[cfg(windows)]tests (including ConPTY, DPAPI and npm shim paths) or Windows clippy branches. The Windows lane remains for the merge queue.Reviews and disposition
Review: ausstehend (Stufe C). Root commissions any reviews and owns acceptance, ready status, labels and Mergify. This worker did not review, queue or merge the change.
Open points / handover
Implemented, locally tested, committed and remotely verified; submitted as draft. Root's review/acceptance and merge-queue Windows evidence remain open. The frozen canonical FU-1015 row still has its dated generic dispatch status; this file-only assignment does not edit PLAN, so orchestration status reconciliation remains with Root. No scope adaptation or product behavior change.