Skip to content

merge queue: checking #1717 on main (9f33f72) - #1745

Closed
mergify[bot] wants to merge 7 commits into
mainfrom
mergify/merge-queue/89a037476c
Closed

merge queue: checking #1717 on main (9f33f72)#1745
mergify[bot] wants to merge 7 commits into
mainfrom
mergify/merge-queue/89a037476c

Conversation

@mergify

@mergify mergify Bot commented Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch tame-valencay-tvg2eg of the default queue, to test #1717 before it merges into main. Pushing to this branch or closing this pull request removes #1717 from the queue.

What this draft tests

Mergify checks that #1717 still passes CI on top of main. CI runs on this draft's code, built in this order:

  1. main at 9f33f72
  2. #1717, the pull request of this batch

🎉 Where it stands: checks passed

CI passed on this draft.

Follow the default queue in the dashboard

What happens next

  • Mergify merges #1717 into main and closes this draft.
Metadata for CI tooling, read by mergify ci 
---
all_scopes: false
checking_base_sha: 9f33f721d52a3a9188a3129118b52bab2cf1bfcd
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 1717
    scopes: []
scopes: []
...
Required conditions of queue rule default for merge
  • check-success = gates (linux)
  • check-success = gates (windows)
  • check-success = red-first
  • github-review-approved [🛡 GitHub repository ruleset rule main-pr-required-checks]
  • label != do-not-merge
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (linux)
    • check-neutral = @github-actions/gates (linux)
    • check-skipped = @github-actions/gates (linux)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (windows)
    • check-neutral = @github-actions/gates (windows)
    • check-skipped = @github-actions/gates (windows)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/red-first
    • check-neutral = @github-actions/red-first
    • check-skipped = @github-actions/red-first
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections
    • check-success = @mergify/Mergify Merge Protections
Required conditions to stay in the queue

Cuarroc and others added 7 commits October 18, 2026 21:08
@Cuarroc @codex
test(design): specify chart labels, gaps and mandatory table twin
c0177e1 
Test-First: src/design/data/charts.test.tsx::the table twin shows the same values as the chart
Test-First: src/design/data/charts.test.tsx::each bar has a text label and value beyond colour
Test-First: src/design/data/charts.test.tsx::sparkline preserves gaps and renders single and constant samples
Test-First: src/design/data/charts.test.tsx::empty and unknown data are words in graphics and table twins
Co-Authored-By: GPT-6 <noreply@openai.com>
@Cuarroc @codex
feat(design): add static charts with a required table twin
53235f4 
Test-First: src/design/data/charts.test.tsx::the table twin shows the same values as the chart
Test-First: src/design/data/charts.test.tsx::each bar has a text label and value beyond colour
Test-First: src/design/data/charts.test.tsx::sparkline preserves gaps and renders single and constant samples
Test-First: src/design/data/charts.test.tsx::empty and unknown data are words in graphics and table twins
Co-Authored-By: gpt-6.1-sol <noreply@openai.com>
@Cuarroc @codex
docs(plan): record DS-X-33 chart package and acceptance
61606e2 
No-Test: plan text only
Co-Authored-By: gpt-6.1-sol <noreply@openai.com>
@Cuarroc @codex
test(design): cover chart formatting and disclosure review findings
ef66e3b 
Test-First: src/design/data/charts.test.tsx::bars and table twins format fractions and thousands in German
Test-First: src/design/data/charts.test.tsx::the table disclosure opens only after clicking its summary
Test-First: src/design/data/charts.test.tsx::empty and unknown data are words in graphics and table twins
Co-Authored-By: gpt-6.1-sol <noreply@openai.com>
@Cuarroc @codex
fix(design): localize chart values and align table presentation
2ef20e6 
Address R1717-A1, B1, C1, D1, D2 and the accepted empty-legend part of E1.

Test-First: src/design/data/charts.test.tsx::bars and table twins format fractions and thousands in German
Test-First: src/design/data/charts.test.tsx::the table disclosure opens only after clicking its summary
Test-First: src/design/data/charts.test.tsx::empty and unknown data are words in graphics and table twins
Co-Authored-By: gpt-6.1-sol <noreply@openai.com>
@Cuarroc @codex
Merge origin/main into codex/ds-x-33 (resolve PLAN.md conflict)
e2199bb 
No-Test: merge commit, docs/PLAN.md conflict only

Co-Authored-By: gpt-6.1-sol <noreply@openai.com>
@mergify @mergify-commit-signer
Merge of #1717
f7345dc
@mergify mergify Bot closed this Oct 20, 2026
@mergify mergify Bot mentioned this pull request Oct 20, 2026
Merged
@mergify
mergify Bot deleted the mergify/merge-queue/89a037476c branch October 20, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Cuarroc