Repository navigation
docs(plan): sync DG-05 to merged #1722 and record retro reviews - #1735
Conversation
PLAN.md DG-05 becomes Erledigt (#1722, merge 87314b5, head fb2aed4, main CI green). DG-00 records the Codex fix round state and that P1/P2 are covered by these rows. The 18.10. review incident note records the retroactive second-family reviews of #1693/#1694/#1702/#1704/#1705. No-Test: docs status sync only Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Cuarroc
added
the
review-ok
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf2b3ec22a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| with one family. Done 20.10. (Root): retroactive second-family reviews by | ||
| NVIDIA nemotron-3-ultra (free kilo lane) against each PR's merge base; no | ||
| confirmed high finding; four small follow-ups (#1705 mouse pick returns no |
There was a problem hiding this comment.
These reviews are explicitly attributed to the “free kilo lane,” but repository policy makes free reviewers supplementary and says they never satisfy required review coverage. Consequently, changing the five Tier-B review debts to “Done” falsely reports compliance without a qualifying second-family review; keep the incident open until eligible reviews are recorded.
AGENTS.md reference: AGENTS.md:L156-L162
Useful? React with 👍 / 👎.
| |---|---|---|---|---|---|---|---|---| | ||
| | DG-00 | Design gate `scripts/dev/design-gate.mjs` + `npm run design:gate`: measures unearned slack, box nesting, empty tabs, eyebrows and equal 1fr grids at 0/2/12 items, ratchet baseline; not wired into `gates.sh` (later decision by Elias) | Root disponiert; Autor Codex | – | Server | B | In Prüfung: #1723 (Draft); Review R1 Claude: APPROVE WITH CONDITIONS (R1723-P1/P2/T1/U1 medium); NACHBESSERN wartet auf Kimi | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-05 | Not-Aus needs a confirmation and exists once (header), Escape/Abbrechen without effect, focus returns | Root disponiert; Autor Codex | – | Server | A | In Prüfung: #1722 (Draft); Review R1 Claude: REQUEST CHANGES (R1722-H1 high: classic UI loses its only Not-Aus) | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-00 | Design gate `scripts/dev/design-gate.mjs` + `npm run design:gate`: measures unearned slack, box nesting, empty tabs, eyebrows and equal 1fr grids at 0/2/12 items, ratchet baseline; not wired into `gates.sh` (later decision by Elias) | Root disponiert; Autor Codex | – | Server | B | In Prüfung: #1723 (Draft); Review R1 Claude: APPROVE WITH CONDITIONS (R1723-P1/P2/T1/U1 medium); NACHBESSERN (Codex, 20.10.): T1/U1/D1 lokal behoben, P1/P2 durch diese Planzeilen erledigt; Push wartet auf den CRLF-Hotfix für `scripts/lib/contrast-gate.test.mjs` | zwei Nicht-Codex-Familien, Gates grün | – | |
There was a problem hiding this comment.
At this commit’s parent, 5fb3e5c is already the merge of CRLF hotfix PR #1733, so “Push wartet auf den CRLF-Hotfix” was false when this line was committed. Leaving DG-00 marked as waiting can incorrectly delay its push and remaining review work; replace the blocker with the actual post-merge state.
AGENTS.md reference: AGENTS.md:L121-L121
Useful? React with 👍 / 👎.
| | DG-00 | Design gate `scripts/dev/design-gate.mjs` + `npm run design:gate`: measures unearned slack, box nesting, empty tabs, eyebrows and equal 1fr grids at 0/2/12 items, ratchet baseline; not wired into `gates.sh` (later decision by Elias) | Root disponiert; Autor Codex | – | Server | B | In Prüfung: #1723 (Draft); Review R1 Claude: APPROVE WITH CONDITIONS (R1723-P1/P2/T1/U1 medium); NACHBESSERN wartet auf Kimi | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-05 | Not-Aus needs a confirmation and exists once (header), Escape/Abbrechen without effect, focus returns | Root disponiert; Autor Codex | – | Server | A | In Prüfung: #1722 (Draft); Review R1 Claude: REQUEST CHANGES (R1722-H1 high: classic UI loses its only Not-Aus) | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-00 | Design gate `scripts/dev/design-gate.mjs` + `npm run design:gate`: measures unearned slack, box nesting, empty tabs, eyebrows and equal 1fr grids at 0/2/12 items, ratchet baseline; not wired into `gates.sh` (later decision by Elias) | Root disponiert; Autor Codex | – | Server | B | In Prüfung: #1723 (Draft); Review R1 Claude: APPROVE WITH CONDITIONS (R1723-P1/P2/T1/U1 medium); NACHBESSERN (Codex, 20.10.): T1/U1/D1 lokal behoben, P1/P2 durch diese Planzeilen erledigt; Push wartet auf den CRLF-Hotfix für `scripts/lib/contrast-gate.test.mjs` | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-05 | Not-Aus needs a confirmation and exists once (header), Escape/Abbrechen without effect, focus returns | Root disponiert; Autor Codex, Fix-Runden Kimi | – | Server | A | Erledigt: #1722 gemergt 2026-10-20 (`87314b5e`, Kopf `fb2aed45`); Reviews Anthropic (R1, R2) + NVIDIA nemotron (R2), Disposition im PR; main-CI grün; Folgepaket R2-L1 (Hinweis im Header bei 900 px) und verwaister Override `shell.css:45` | zwei Nicht-Codex-Familien, Gates grün | – | |
There was a problem hiding this comment.
This Tier-A row still requires reviews from two non-Codex families, but the status names only Anthropic and NVIDIA nemotron. The only NVIDIA mechanism documented by this change is the free Kilo route on line 959, while the Tier-A reviewer rule explicitly says free feedback never counts, so Anthropic remains the sole qualifying family; record an eligible second review or retain the review debt instead of presenting the requirement as fulfilled.
AGENTS.md reference: AGENTS.md:L325-L325
Useful? React with 👍 / 👎.
| | DG-00 | Design gate `scripts/dev/design-gate.mjs` + `npm run design:gate`: measures unearned slack, box nesting, empty tabs, eyebrows and equal 1fr grids at 0/2/12 items, ratchet baseline; not wired into `gates.sh` (later decision by Elias) | Root disponiert; Autor Codex | – | Server | B | In Prüfung: #1723 (Draft); Review R1 Claude: APPROVE WITH CONDITIONS (R1723-P1/P2/T1/U1 medium); NACHBESSERN wartet auf Kimi | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-05 | Not-Aus needs a confirmation and exists once (header), Escape/Abbrechen without effect, focus returns | Root disponiert; Autor Codex | – | Server | A | In Prüfung: #1722 (Draft); Review R1 Claude: REQUEST CHANGES (R1722-H1 high: classic UI loses its only Not-Aus) | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-00 | Design gate `scripts/dev/design-gate.mjs` + `npm run design:gate`: measures unearned slack, box nesting, empty tabs, eyebrows and equal 1fr grids at 0/2/12 items, ratchet baseline; not wired into `gates.sh` (later decision by Elias) | Root disponiert; Autor Codex | – | Server | B | In Prüfung: #1723 (Draft); Review R1 Claude: APPROVE WITH CONDITIONS (R1723-P1/P2/T1/U1 medium); NACHBESSERN (Codex, 20.10.): T1/U1/D1 lokal behoben, P1/P2 durch diese Planzeilen erledigt; Push wartet auf den CRLF-Hotfix für `scripts/lib/contrast-gate.test.mjs` | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-05 | Not-Aus needs a confirmation and exists once (header), Escape/Abbrechen without effect, focus returns | Root disponiert; Autor Codex, Fix-Runden Kimi | – | Server | A | Erledigt: #1722 gemergt 2026-10-20 (`87314b5e`, Kopf `fb2aed45`); Reviews Anthropic (R1, R2) + NVIDIA nemotron (R2), Disposition im PR; main-CI grün; Folgepaket R2-L1 (Hinweis im Header bei 900 px) und verwaister Override `shell.css:45` | zwei Nicht-Codex-Familien, Gates grün | – | |
There was a problem hiding this comment.
The completed goal says the sole control is in the header, but the merged implementation deliberately renders <EmergencyStop /> in classic Settings when d1_neue_oberflaeche is disabled (src/components/settings/GeneralTab.tsx:114-120), and the regression test pins that behavior. Restore the split description—header in the new shell, Settings in the classic UI—so this completed row actually states what is true after merge.
AGENTS.md reference: AGENTS.md:L121-L121
Useful? React with 👍 / 👎.
| confirmed high finding; four small follow-ups (#1705 mouse pick returns no | ||
| focus, #1704 toast `onAction` without try/finally, #1693 `motion.css` | ||
| fallback, #1694 `shot.mjs` motion flag intent). |
There was a problem hiding this comment.
The four new review follow-ups are only parenthetical fragments, and the DG-05 follow-ups on line 989 likewise have no package IDs, owner, status, next step, or verifiable acceptance. Because this plan is the dispatch source, these defects cannot be assigned or reliably closed and can silently disappear; add bounded rows for them—even if parked by the focus stop—or explicitly disposition them as not planned.
AGENTS.md reference: AGENTS.md:L190-L194
Useful? React with 👍 / 👎.
| | DG-00 | Design gate `scripts/dev/design-gate.mjs` + `npm run design:gate`: measures unearned slack, box nesting, empty tabs, eyebrows and equal 1fr grids at 0/2/12 items, ratchet baseline; not wired into `gates.sh` (later decision by Elias) | Root disponiert; Autor Codex | – | Server | B | In Prüfung: #1723 (Draft); Review R1 Claude: APPROVE WITH CONDITIONS (R1723-P1/P2/T1/U1 medium); NACHBESSERN wartet auf Kimi | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-05 | Not-Aus needs a confirmation and exists once (header), Escape/Abbrechen without effect, focus returns | Root disponiert; Autor Codex | – | Server | A | In Prüfung: #1722 (Draft); Review R1 Claude: REQUEST CHANGES (R1722-H1 high: classic UI loses its only Not-Aus) | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-00 | Design gate `scripts/dev/design-gate.mjs` + `npm run design:gate`: measures unearned slack, box nesting, empty tabs, eyebrows and equal 1fr grids at 0/2/12 items, ratchet baseline; not wired into `gates.sh` (later decision by Elias) | Root disponiert; Autor Codex | – | Server | B | In Prüfung: #1723 (Draft); Review R1 Claude: APPROVE WITH CONDITIONS (R1723-P1/P2/T1/U1 medium); NACHBESSERN (Codex, 20.10.): T1/U1/D1 lokal behoben, P1/P2 durch diese Planzeilen erledigt; Push wartet auf den CRLF-Hotfix für `scripts/lib/contrast-gate.test.mjs` | zwei Nicht-Codex-Familien, Gates grün | – | | ||
| | DG-05 | Not-Aus needs a confirmation and exists once (header), Escape/Abbrechen without effect, focus returns | Root disponiert; Autor Codex, Fix-Runden Kimi | – | Server | A | Erledigt: #1722 gemergt 2026-10-20 (`87314b5e`, Kopf `fb2aed45`); Reviews Anthropic (R1, R2) + NVIDIA nemotron (R2), Disposition im PR; main-CI grün; Folgepaket R2-L1 (Hinweis im Header bei 900 px) und verwaister Override `shell.css:45` | zwei Nicht-Codex-Familien, Gates grün | – | |
There was a problem hiding this comment.
The row asserts main-CI grün, but this commit’s evidence lists only the offline plan check, secret scan, and local pre-push run, while its NICHT ABGEDECKT section explicitly excludes external service state. I also could not cross-check GitHub because gh has no authentication in this checkout, so no observed run, command output, or checked SHA supports the new CI status; verify and record that evidence or leave main CI unverified.
AGENTS.md reference: AGENTS.md:L45-L48
Useful? React with 👍 / 👎.
Merge Queue Status
This pull request spent 8 minutes 57 seconds in the queue, including 8 minutes 12 seconds running CI. Required conditions to merge
|
Der Plan zeigt jetzt, dass die Not-Aus-Bestätigung (#1722) fertig und gemergt ist. Außerdem steht drin, dass die fünf nachträglichen Zweitprüfungen erledigt sind und keinen echten schweren Fehler gefunden haben. Für DG-00 (#1723) steht der aktuelle Stand der Nachbesserung im Plan.
Report
Change (docs only,
docs/PLAN.md, +7/−6):87314b5e, headfb2aed45), reviews Anthropic (R1, R2) + NVIDIA nemotron (R2), main CI green; follow-ups R2-L1 and orphanedshell.css:45override.Evidence
node scripts/plan-check.mjs --offlineexit 0 (0 Befunde).bash scripts/ci/secret-scan.shexit 0.git pushwith the pre-push hook (gates.sh lane prepush) exit 0, 706 s, worktree plan-sync-dg05 @cf2b3ec2on base5fb3e5ca. Push verified withgit ls-remote=cf2b3ec2.NICHT ABGEDECKT: Linux half (
#[cfg(unix)]tests), Windows arms of clippy beyond this PC run; external service state. Docs-only change, no runtime effect.Review: tier C (docs, no runtime effect) — gates suffice, no external review required.
🤖 Generated with Claude Code