Skip to content

merge queue: checking #1694 on main (f3fb146), stacked on #1704 - #1709

Closed
mergify[bot] wants to merge 14 commits into
mainfrom
mergify/merge-queue/0eb2d20bf2
Closed

merge queue: checking #1694 on main (f3fb146), stacked on #1704#1709
mergify[bot] wants to merge 14 commits into
mainfrom
mergify/merge-queue/0eb2d20bf2

Conversation

@mergify

@mergify mergify Bot commented Oct 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch suitable-hure-g8s1b7 of the default queue, to test #1694 before it merges into main. Pushing to this branch or closing this pull request removes #1694 from the queue.

What this draft tests

Mergify checks that #1694 still passes CI once combined with everything queued ahead of it. CI runs on this draft's code, built in this order:

  1. main at f3fb146
  2. the pull request queued ahead of this batch, listed below, which brings the tip to 2eb4ee0
  3. #1694, the pull request of this batch

The check is speculative: it assumes the pull requests ahead will merge, so it starts without waiting for them.

🎉 Where it stands: checks passed

CI passed on this draft.

Follow the default queue in the dashboard

What happens next

  • Once the pull requests ahead have merged, Mergify merges #1694 into main and closes this draft.
  • If a pull request ahead fails or leaves the queue without merging, this batch is requeued and checked again on a new draft: these checks assumed it would merge.

Tip

A red check is not necessarily caused by this batch. These checks run on a tip that also carries the commits of the pull request ahead, so a failure here can come from it as much as from #1694. See only this batch's changes.

Queued ahead of this batch

This pull request entered the queue before this batch and is not part of it.

Metadata for CI tooling, read by mergify ci 
---
all_scopes: false
checking_base_sha: 2eb4ee031317747047b8a0c76144ffe68ec42df3
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 1694
    scopes: []
scopes: []
...
Required conditions of queue rule default for merge
  • check-success = gates (linux)
  • check-success = gates (windows)
  • check-success = red-first
  • github-review-approved [🛡 GitHub repository ruleset rule main-pr-required-checks]
  • label != do-not-merge
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (linux)
    • check-neutral = @github-actions/gates (linux)
    • check-skipped = @github-actions/gates (linux)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (windows)
    • check-neutral = @github-actions/gates (windows)
    • check-skipped = @github-actions/gates (windows)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/red-first
    • check-neutral = @github-actions/red-first
    • check-skipped = @github-actions/red-first
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections
    • check-success = @mergify/Mergify Merge Protections
Required conditions to stay in the queue

Cuarroc and others added 14 commits October 17, 2026 06:45
@Cuarroc @claude
test(dev): DS-H-07b red tests for shot.mjs --theme, --motion, --reduc…
9e721ed 
…ed, --dpr, --wait, --video

Failing first: shot.mjs does not know these options yet.

Test-First: scripts/dev/shot.test.mjs::--dpr 1.5 writes a png at 1.5x size with a dpr suffix
Test-First: scripts/dev/shot.test.mjs::--motion lively stores the motion mode before load
Test-First: scripts/dev/shot.test.mjs::--motion calm leaves the app without a stored motion mode
Test-First: scripts/dev/shot.test.mjs::--reduced emulates reduced motion
Test-First: scripts/dev/shot.test.mjs::--theme dark writes only the dark png
Test-First: scripts/dev/shot.test.mjs::--wait delays the screenshot until a late frame is visible
Test-First: scripts/dev/shot.test.mjs::--video writes a webm

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
feat(dev): DS-H-07b shot.mjs motion, dpr and video
60ffb18 
Adds --theme, --motion calm|lively|off (stored before load, mirror of
motionMode.ts), --reduced, --dpr, --wait and --video. Without the new
options, calls and output are unchanged.

Test-First: scripts/dev/shot.test.mjs::--dpr 1.5 writes a png at 1.5x size with a dpr suffix
Test-First: scripts/dev/shot.test.mjs::--motion lively stores the motion mode before load
Test-First: scripts/dev/shot.test.mjs::--motion calm leaves the app without a stored motion mode
Test-First: scripts/dev/shot.test.mjs::--reduced emulates reduced motion
Test-First: scripts/dev/shot.test.mjs::--theme dark writes only the dark png
Test-First: scripts/dev/shot.test.mjs::--wait delays the screenshot until a late frame is visible
Test-First: scripts/dev/shot.test.mjs::--video writes a webm

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
docs(plan): DS-H-07b row
b910f48 
No-Test: plan text only

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
test(design): DS-X-28 red tests for the useToast queue
5d28fd4 
Compiling stub plus tests; the tests fail until the hook is implemented.

Test-First: src/design/layout/toast.queue.test.tsx::push returns an id and dismiss removes and action runs once
Test-First: src/design/layout/toast.queue.test.tsx::shows at most three toasts and the fourth waits until one leaves
Test-First: src/design/layout/toast.queue.test.tsx::leaves without an exit animation when motion is off

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
feat(design): DS-X-28 useToast queue with optional action
d2b233b 
useToast() returns push/dismiss/region; at most three toasts show, the rest
wait; the action runs once; leaving goes through useExitTransition.

Test-First: src/design/layout/toast.queue.test.tsx::push returns an id and dismiss removes and action runs once
Test-First: src/design/layout/toast.queue.test.tsx::shows at most three toasts and the fourth waits until one leaves

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
docs(plan): DS-X-28 row
36f2054 
No-Test: plan text only

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
Merge origin/main into claude/ds-h-07b
637e354 
Conflict resolution only: docs/PLAN.md keeps the DS-H-07a row from main
and the DS-H-07b row of this PR.

No-Test: merge of main, conflict resolution only

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
test(design): DS-X-28 cover dismissing a waiting toast
6818bc2 
A toast beyond the visible three is dismissed while it waits; it must
never appear once a slot frees up (review R1704-F1).

No-Test: adds coverage for existing behaviour (review R1704-F1), no source change

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
test(dev): DS-H-07b red test for shot.mjs --theme dark with --check-tab
86aa62a 
Review R1694-F1: the tab check ran only for the light scheme, so a dark-only
run left report.tab null and exited 1.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
fix(dev): DS-H-07b shot.mjs runs the tab check on the first captured …
1155d56 
…scheme

Review R1694-F1: with --theme dark the check was skipped and the run failed.

Test-First: scripts/dev/shot.test.mjs::--theme dark supports --check-tab

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
test(dev): DS-H-07b --wait test asserts the captured pixel on a stati…
2276a7d 
…c fixture

Review R1694-F2: the fixture had a continuously rotating element, so differing
PNG bytes did not prove the late change was captured. The fixture is now static
with one delayed background flip; the test reads the first pixel with and
without --wait.

No-Test: adds coverage for existing behaviour (review R1694-F2)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Cuarroc @claude
test(dev): DS-H-07b keep the historical --wait test name
0cbe3f2 
The earlier Test-First trailer names this test; the rename broke red-first.

No-Test: test rename only, behaviour unchanged

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@mergify @mergify-commit-signer
Merge of #1704
2eb4ee0
@mergify @mergify-commit-signer
Merge of #1694
3cb72bb
@mergify mergify Bot closed this Oct 18, 2026
@mergify mergify Bot mentioned this pull request Oct 18, 2026
Merged
@mergify
mergify Bot deleted the mergify/merge-queue/0eb2d20bf2 branch October 18, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Cuarroc