Repository navigation
merge queue: checking #1647 on main (f42baa3), stacked on #1646 - #1654
Closed
mergify[bot] wants to merge 9 commits into
Closed
mergify[bot] wants to merge 9 commits into
mergify[bot] wants to merge 9 commits into
Conversation
Named tests for the figure sheet of docs/design/hall/ASSETS.md §6: every pose comes from exactly one StateForm or unknown, every role has a frame for every pose, at most eight colours per frame, unknown never shows the work pose, roles differ by silhouette, and the role is also text. The placeholder raster moves to figures/roles.px.ts and poses.ts is a stub, so the tests compile and fail. Test-First: src/design/hall/figures.test.ts::every pose maps to exactly one StateForm or unknown Test-First: src/design/hall/figures.test.ts::every state form and unknown maps to exactly one pose Test-First: src/design/hall/figures.test.ts::every role has a frame for every pose Test-First: src/design/hall/figures.test.ts::no figure frame uses more than eight colours Test-First: src/design/hall/figures.test.ts::unknown never shows the working pose Test-First: src/design/hall/figures.test.ts::the four roles differ by silhouette and not only by colour Test-First: src/design/hall/figures.test.ts::role is also text Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Four role figures (plan, build, check, ops) of docs/design/hall/ASSETS.md §6 in figures/roles.px.ts: one body, a head overlay per role for silhouette and prop (bun and pencil, hard hat, cap and goggles, headset), and eight poses laid over each role's ready frame as shared deltas, 12 frames per role, 48 in the atlas (256 x 192, 6.5 KB per theme). The role colour is drawn once and swapped per role; no frame uses more than eight palette entries. poses.ts maps each observed StateForm to its pose, anything else to unknown and no run to the stance ready; the role words live in de.ts. Test-First: src/design/hall/figures.test.ts::every pose maps to exactly one StateForm or unknown Test-First: src/design/hall/figures.test.ts::every state form and unknown maps to exactly one pose Test-First: src/design/hall/figures.test.ts::every role has a frame for every pose Test-First: src/design/hall/figures.test.ts::no figure frame uses more than eight colours Test-First: src/design/hall/figures.test.ts::unknown never shows the working pose Test-First: src/design/hall/figures.test.ts::the four roles differ by silhouette and not only by colour Test-First: src/design/hall/figures.test.ts::role is also text Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tab bar without Betrieb, alias with trailing slash and query, Betrieb area opened from the empty board, a notice for a failed profile read, and e2e/history guards for the retired path. Test-First: src/screens/leitstand/LeitstandRoute.test.tsx::the Fabrik tab bar has no Betrieb tab Test-First: src/screens/leitstand/LeitstandRoute.test.tsx::an empty board offers Auftrag einreihen and opens the Betrieb area Test-First: src/shell/mount/routing.test.ts::retired path with trailing slash resolves to /betrieb Test-First: src/shell/mount/routing.test.ts::retired path with a query string keeps the query and resolves to /betrieb Test-First: src/shell/mount/routing.test.ts::the retired Betrieb path is no Leitstand route any more Test-First: src/shell/mount/betrieb.mount.test.tsx::a failed profile read shows a notice Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: plan text only Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Remove the Betrieb branch, tab and key leitstand.tab.betrieb from the Fabrik; the empty-board step opens /betrieb. resolveAlias normalises a trailing slash and a query string. A failed profile read on /betrieb shows an honest notice. Regression-For: d866d7d Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: plan text only Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
No-Test: plan text only Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch financial-lardon-bkdrgu of the
defaultqueue, to test #1647 before it merges intomain. Pushing to this branch or closing this pull request removes #1647 from the queue.What this draft tests
Mergify checks that #1647 still passes CI once combined with everything queued ahead of it. CI runs on this draft's code, built in this order:
mainatf42baa3cf3d362The check is speculative: it assumes the pull requests ahead will merge, so it starts without waiting for them.
🎉 Where it stands: checks passed
CI passed on this draft.
Follow the
defaultqueue in the dashboardWhat happens next
mainand closes this draft.Tip
A red check is not necessarily caused by this batch. These checks run on a tip that also carries the commits of the pull request ahead, so a failure here can come from it as much as from #1647. See only this batch's changes.
Queued ahead of this batch
This pull request entered the queue before this batch and is not part of it.
Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
defaultfor mergecheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergemain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge ProtectionsRequired conditions to stay in the queue
-conflict-draftbase = maincheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergelabel = review-okmain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge Protections