Skip to content

merge queue: checking #1642 on main (1256c96) - #1644

Closed
mergify[bot] wants to merge 4 commits into
mainfrom
mergify/merge-queue/7be637f217
Closed

merge queue: checking #1642 on main (1256c96)#1644
mergify[bot] wants to merge 4 commits into
mainfrom
mergify/merge-queue/7be637f217

Conversation

@mergify

@mergify mergify Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch astonishing-myrtille-vnd8tm of the default queue, to test #1642 before it merges into main. Pushing to this branch or closing this pull request removes #1642 from the queue.

What this draft tests

Mergify checks that #1642 still passes CI on top of main. CI runs on this draft's code, built in this order:

  1. main at 1256c96
  2. #1642, the pull request of this batch

🎉 Where it stands: checks passed

CI passed on this draft.

Follow the default queue in the dashboard

What happens next

  • Mergify merges #1642 into main and closes this draft.
Metadata for CI tooling, read by mergify ci 
---
all_scopes: false
checking_base_sha: 1256c965e1d27d0ad82e3b43b51e992b92f4c0a3
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 1642
    scopes: []
scopes: []
...
Required conditions of queue rule default for merge
  • check-success = gates (linux)
  • check-success = gates (windows)
  • check-success = red-first
  • github-review-approved [🛡 GitHub repository ruleset rule main-pr-required-checks]
  • label != do-not-merge
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (linux)
    • check-neutral = @github-actions/gates (linux)
    • check-skipped = @github-actions/gates (linux)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (windows)
    • check-neutral = @github-actions/gates (windows)
    • check-skipped = @github-actions/gates (windows)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/red-first
    • check-neutral = @github-actions/red-first
    • check-skipped = @github-actions/red-first
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections
    • check-success = @mergify/Mergify Merge Protections
Required conditions to stay in the queue

Cuarroc and others added 4 commits October 16, 2026 16:56
@Cuarroc @claude
test(design): DS-H-02a red tests for hall tiles and generator checks
0294d8b 
The layout grid needs tiles the atlas does not have yet; the build script gets
negative cases (malformed/duplicate id, wrong size, too many colours, atlas
overflow, non-hex token), tolerant token blocks, a missing output directory and
a bare --out; usePixelScale gets a server snapshot.

Test-First: src/design/hall/tiles.test.ts::every tile used by the layout exists in the atlas
Test-First: src/design/hall/sprites.test.ts::the build rejects a malformed frame id
Test-First: src/design/hall/sprites.test.ts::the build rejects a duplicate frame id
Test-First: src/design/hall/sprites.test.ts::the build rejects a frame of the wrong size
Test-First: src/design/hall/sprites.test.ts::the build rejects a figure frame with more than eight colours
Test-First: src/design/hall/sprites.test.ts::the build rejects an atlas over its size limit
Test-First: src/design/hall/sprites.test.ts::the build rejects a token that is not an opaque hex colour
Test-First: src/design/hall/sprites.test.ts::the build reads token blocks without a space before the brace
Test-First: src/design/hall/sprites.test.ts::the build creates a missing output directory
Test-First: src/design/hall/sprites.test.ts::the build fails clearly when --out has no value
Test-First: src/design/hall/pixelScale.test.ts::server rendering assumes a device pixel ratio of 1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Cuarroc @claude
feat(design): DS-H-02a hall tiles and generator checks
9d6c645 
Seven 16x16 tiles drawn as text rasters (floor, wall, door, belt, return
path and the two turns that join them) plus the floor layout that uses
them; the committed atlases are the generator's output.

Generator hardening from the DS-H-01 review: --root for tests, a bare
--out or --root fails with a clear message, the output directory is
created, and token blocks are found regardless of spacing before the
brace. usePixelScale gets a server snapshot of ratio 1.

Test-First: src/design/hall/tiles.test.ts::every tile used by the layout exists in the atlas
Test-First: src/design/hall/sprites.test.ts::the build rejects a malformed frame id
Test-First: src/design/hall/sprites.test.ts::the build rejects a duplicate frame id
Test-First: src/design/hall/sprites.test.ts::the build rejects a frame of the wrong size
Test-First: src/design/hall/sprites.test.ts::the build rejects a figure frame with more than eight colours
Test-First: src/design/hall/sprites.test.ts::the build rejects an atlas over its size limit
Test-First: src/design/hall/sprites.test.ts::the build rejects a token that is not an opaque hex colour
Test-First: src/design/hall/sprites.test.ts::the build reads token blocks without a space before the brace
Test-First: src/design/hall/sprites.test.ts::the build creates a missing output directory
Test-First: src/design/hall/sprites.test.ts::the build fails clearly when --out has no value
Test-First: src/design/hall/pixelScale.test.ts::server rendering assumes a device pixel ratio of 1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Cuarroc @claude
docs(plan): DS-H-02a row done with #1642
1a296cd 
No-Test: plan text only

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mergify @mergify-commit-signer
Merge of #1642
5a43793
@mergify mergify Bot closed this Oct 16, 2026
@mergify mergify Bot mentioned this pull request Oct 16, 2026
Merged
@mergify
mergify Bot deleted the mergify/merge-queue/7be637f217 branch October 16, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Cuarroc