Skip to content

merge queue: checking #1625 on main (5667eea), stacked on #1624 - #1627

Closed
mergify[bot] wants to merge 9 commits into
mainfrom
mergify/merge-queue/6be6afc899
Closed

merge queue: checking #1625 on main (5667eea), stacked on #1624#1627
mergify[bot] wants to merge 9 commits into
mainfrom
mergify/merge-queue/6be6afc899

Conversation

@mergify

@mergify mergify Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch worldwide-painmie-rzvw9y of the default queue, to test #1625 before it merges into main. Pushing to this branch or closing this pull request removes #1625 from the queue.

What this draft tests

Mergify checks that #1625 still passes CI once combined with everything queued ahead of it. CI runs on this draft's code, built in this order:

  1. main at 5667eea
  2. the pull request queued ahead of this batch, listed below, which brings the tip to 857d365
  3. #1625, the pull request of this batch

The check is speculative: it assumes the pull requests ahead will merge, so it starts without waiting for them.

🎉 Where it stands: checks passed

CI passed on this draft.

Follow the default queue in the dashboard

What happens next

  • Once the pull requests ahead have merged, Mergify merges #1625 into main and closes this draft.
  • If a pull request ahead fails or leaves the queue without merging, this batch is requeued and checked again on a new draft: these checks assumed it would merge.

Tip

A red check is not necessarily caused by this batch. These checks run on a tip that also carries the commits of the pull request ahead, so a failure here can come from it as much as from #1625. See only this batch's changes.

Queued ahead of this batch

This pull request entered the queue before this batch and is not part of it.

Metadata for CI tooling, read by mergify ci 
---
all_scopes: false
checking_base_sha: 857d365be5332f4864041ccfc4da1be6920fa1ae
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 1625
    scopes: []
scopes: []
...
Required conditions of queue rule default for merge
  • check-success = gates (linux)
  • check-success = gates (windows)
  • check-success = red-first
  • github-review-approved [🛡 GitHub repository ruleset rule main-pr-required-checks]
  • label != do-not-merge
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (linux)
    • check-neutral = @github-actions/gates (linux)
    • check-skipped = @github-actions/gates (linux)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/gates (windows)
    • check-neutral = @github-actions/gates (windows)
    • check-skipped = @github-actions/gates (windows)
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-success = @github-actions/red-first
    • check-neutral = @github-actions/red-first
    • check-skipped = @github-actions/red-first
  • any of [🛡 GitHub repository ruleset rule main-pr-required-checks]:
    • check-neutral = @mergify/Mergify Merge Protections
    • check-skipped = @mergify/Mergify Merge Protections
    • check-success = @mergify/Mergify Merge Protections
Required conditions to stay in the queue

Cuarroc and others added 9 commits October 16, 2026 10:29
@Cuarroc @claude
test(leitstand): DS-T-03 red tests for the proven card lamp
17548fc 
An unknown column or worker status still reads "Läuft", and a passed
test still reads "Fertig" on card and flow node. These tests pin the
fix through lampFor, AgentCard and FlowTab.

Test-First: src/screens/leitstand/lamps/lampFor.test.ts::returns unknown for a column the map does not know
Test-First: src/screens/leitstand/lamps/lampFor.test.ts::returns unknown for a worker status it does not know
Test-First: src/screens/leitstand/lamps/lampFor.test.ts::a passed test is worded as a test result
Test-First: src/screens/leitstand/AgentCard.test.tsx::a card of an unknown column shows no running lamp
Test-First: src/screens/leitstand/flow/FlowTab.test.tsx::a node of an unknown column shows the same neutral lamp as the card

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Cuarroc @claude
fix(design): DS-T-03 card lamp says what is proven
936414e 
lampFor no longer falls back to "Läuft": a column outside COLUMN_FORM
or a worker status other than running is the neutral unknown lamp
(DS-T-02 form), on the card and the flow node alike. The proven lamp
says "Test bestanden" plus the age of the test run (testedAt) instead
of "Fertig", so green names its evidence. Which head was tested is not
on BoardCard yet (seam work, out of scope).

Deliberate test adaptations: the three "Fertig" expectations now read
"Test bestanden"; lampFor calls pass the fixed clock.

Regression-For: 17548fc
Test-First: src/screens/leitstand/lamps/lampFor.test.ts::returns unknown for a column the map does not know
Test-First: src/screens/leitstand/lamps/lampFor.test.ts::returns unknown for a worker status it does not know
Test-First: src/screens/leitstand/lamps/lampFor.test.ts::a passed test is worded as a test result
Test-First: src/screens/leitstand/AgentCard.test.tsx::a card of an unknown column shows no running lamp
Test-First: src/screens/leitstand/flow/FlowTab.test.tsx::a node of an unknown column shows the same neutral lamp as the card

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Cuarroc @claude
test(plan): PLAN-GATE red test for the plan-check gate
4507c1a 
Drives gates.sh run plan-check on a fixture with a known finding and on a
clean plan; red until the gate exists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Cuarroc @claude
ci(plan): PLAN-GATE run the plan check as a gate
5cb45b3 
Gate plan-check (node scripts/plan-check.mjs --offline) joins the lanes
precommit, prepush, branchpush, linux and linux_1. Offline keeps GitHub and
the events log out of the verdict (listed as NICHT GEPRUEFT). docs/decisions.md
is now read by a gate, so lane-plan classifies it heavy.

Test-First: scripts/lib/plan-gate.test.mjs::plan-check gate fails on a plan finding and passes on a clean plan
Test-First: scripts/lib/plan-gate.test.mjs::plan-check gate runs in the local and the linux CI lanes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Cuarroc @claude
fix(design): DS-T-03 keep the test-age wording in the lamp texts
1ebf308 
The ", " separator of the passed-test word sat in lampFor.ts and
tripped the hardcoded-UI-string ratchet. The whole wording is now one
texts.ts template filled through the existing fill helper.

Regression-For: 17548fc

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Cuarroc @claude
docs(plan): DS-T-03 row below DS-X-04, true after merge
7bab0f4 
Moves the planned DS-T-03 row of the pixel-factory table to the Z2
table (placement fixed by Root), so the ID stays unique (plan-model
duplicate-id), and names #1624 in the note on own-PR rows.

No-Test: plan row only

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Cuarroc @claude
docs(plan): PLAN-GATE row done with #1625; book 16.10. quota decision
068f9a7 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mergify @mergify-commit-signer
Merge of #1624
857d365
@mergify @mergify-commit-signer
Merge of #1625
9d253cb
@mergify mergify Bot closed this Oct 16, 2026
@mergify mergify Bot mentioned this pull request Oct 16, 2026
Merged
@mergify
mergify Bot deleted the mergify/merge-queue/6be6afc899 branch October 16, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cuarroc Cuarroc Awaiting requested review from Cuarroc Cuarroc will be requested when the pull request is marked ready for review Cuarroc is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Cuarroc