Skip to content

merge queue: checking #1588 on main (c9d4ca3) #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mergify wants to merge 3 commits into from
Closed

merge queue: checking #1588 on main (c9d4ca3) #1590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23f24d3
docs: require PLAN currency checks in reviews
Cuarroc Oct 15, 2026
aecad6d
docs: fix PR 1588 review findings
Cuarroc Oct 15, 2026
2e60aa4
Merge of #1588
mergify[bot] Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .agents/skills/projecta-workflow/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ test first, then the fix.
(initial dispatch: 300); record the overrun and forcing finding IDs.
Current eligible reviewers and credit limits: coordinator's private record;
follow AGENTS.md's recorded exceptions, never infer live availability.
- Every review checks `docs/PLAN.md` at the head: the PR's `Plan-ID:` row must
state what is true after merge, and the PR must leave no other row, user
section or decision inbox stale; cross-check against `gh`. A mismatch is a
medium finding (high if the user section asks for something already done)
and must be fixed in the same PR before `review-ok`.
- Use recursive prompting selectively for complex plans/dependencies, hard
diagnosis or demanding designs. Keep requirements/acceptance, necessary
subquestions, first solution, one neutral extra check (no defect is valid),
Expand Down
5 changes: 5 additions & 0 deletions .claude/skills/projecta-workflow/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ test first, then the fix.
(initial dispatch: 300); record the overrun and forcing finding IDs.
Current eligible reviewers and credit limits: coordinator's private record;
follow AGENTS.md's recorded exceptions, never infer live availability.
- Every review checks `docs/PLAN.md` at the head: the PR's `Plan-ID:` row must
state what is true after merge, and the PR must leave no other row, user
section or decision inbox stale; cross-check against `gh`. A mismatch is a
medium finding (high if the user section asks for something already done)
and must be fixed in the same PR before `review-ok`.
- Use recursive prompting selectively for complex plans/dependencies, hard
diagnosis or demanding designs. Keep requirements/acceptance, necessary
subquestions, first solution, one neutral extra check (no defect is valid),
Expand Down
1 change: 1 addition & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ starts with "## Report" on package branches.
-->

## Report
Plan-ID: <PLAN-ID>

**Package:** <ID from docs/PLAN.md> · **Review tier:** A / B / C (AGENTS.md, rule 5)

Expand Down
2 changes: 2 additions & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ the PR report; no third review round. Evidence is bound to the actual candidate;
changes invalidate the affected evidence, so review the delta again. A finding
without `file:line` counts as unproven.

Every review checks `docs/PLAN.md` at the head: the PR's own row (identified by `Plan-ID:`) states what is true after merge, and changes in the PR leave no other row, the user section or decision inbox stale; cross-check against `gh`. A mismatch is a medium finding, or high if the user section asks for something already done, and must be fixed in the same PR before `review-ok` (user order 2026-10-15: the plan must never be stale).

Use recursive prompting selectively for complex plans, dependencies, hard
diagnosis or designs with checkable criteria (user order 2026-10-08), following
`docs/development/prompting.md`. Preserve requirements and acceptance; ask only
Expand Down
1 change: 1 addition & 0 deletions docs/PLAN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,7 @@ Keine zweite Roadmap neben dem Plan; der Plan bleibt die einzige Quelle.
| ID | Ziel | Abhängigkeit | Status |
|---|---|---|---|
| PLAN-AUTO-1 | PLAN-Modell + `npm run plan:check` (Befunde: PR ohne Planzeile, Status widerspricht GitHub, unbekannte Abhängigkeit, Job ohne Zeile, Entscheidung ohne Zeile, Plan veraltet) | – | läuft: Draft-PR #1564, 15.10. (`gh pr list --search "PLAN-AUTO-1"`) |
| AGENTS-PLAN-REVIEW | Reviews prüfen PLAN-Aktualität (eigene Zeile über Plan-ID, Nutzerbereich, Entscheidungs-Eingang gegen gh) | Root | Erledigt mit Merge von PR #1588 |
| PLAN-AUTO-2 | Gate: jeder Paket-PR nennt eine `Plan-ID:`, die im Plan steht | PLAN-AUTO-1 | geplant |
| PLAN-AUTO-3 | Status-Abgleich als Skript statt LLM: stündlich, Docs-PR, automatisch eingereiht | PLAN-AUTO-1 | geplant |
| PLAN-NORM-n | Pakettabellen auf feste Spalten (ID, Ziel, Richtung, Version, Abhängigkeit, Status, Owner), je ≤300 Zeilen | PLAN-AUTO-1 | geplant |
Expand Down
Loading