Repository navigation
merge queue: checking #1533 on main (56c22d1) - #1534
Closed
mergify[bot] wants to merge 4 commits into
Closed
mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
…de (COMP-4-3) Red at this commit: the node shows no proof strip and a done node with a passed test still reads "ohne Beweis". Test-First: src/screens/leitstand/flow/FlowTab.test.tsx::shows an unconnected red-first badge on the node Test-First: src/screens/leitstand/flow/FlowTab.test.tsx::lifts the node lamp to done when the test passed Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… BLOCKED) WIP handover, not for merge. Behaviour is done and green in jsdom, but the flow node frame is fixed at 76 px (FlowGraph.tsx NODE_H, out of scope) and the four-badge strip needs about 158 px of content: in a browser it pushes task, lamp and quota out of the clipped node. Needs a decision on node geometry or a compact strip before this can ship. No-Test: covered by the two Test-First tests of commit 1de2180; this commit only adds the fix and corrects the lamp assertion Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Root decision 15.10. Option 1: the full four-badge strip needs ~158 px, the flow node is 76 px, so the node gets a compact variant of the COMP-4-2 strip: one 24-px pill, one cell per field, a mark per value (the words stay in the tooltip and for assistive tech), "RF" for red-first, "n/m" for gates, the commit and run only in the PR tooltip. Same mapping and honesty rule: an unconnected field is a dash with the words "noch nicht verbunden" behind it, never a pass mark; the PR shows only with a web address. NODE_H 76 -> 112 (a two-line task, lamp row, quota row and the pill need 102 px in a browser), GAP_Y 56 -> 40 so the arrows stay short. Test-First: src/screens/leitstand/proof/ProofStrip.test.tsx::draws the compact strip as one row of four cells and never a pass mark without data Test-First: src/screens/leitstand/proof/ProofStrip.test.tsx::keeps the words of every compact value for assistive tech and the tooltip Test-First: src/screens/leitstand/flow/FlowTab.test.tsx::draws the node's proof strip as the one-line variant Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch parental-romesco-z05r1w of the
defaultqueue, to test #1533 before it merges intomain. Pushing to this branch or closing this pull request removes #1533 from the queue.What this draft tests
Mergify checks that #1533 still passes CI on top of
main. CI runs on this draft's code, built in this order:mainat56c22d1🎉 Where it stands: checks passed
CI passed on this draft.
Follow the
defaultqueue in the dashboardWhat happens next
mainand closes this draft.Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
defaultfor mergecheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergemain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge ProtectionsRequired conditions to stay in the queue
-conflict-draftbase = maincheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergelabel = review-okmain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge Protections