Repository navigation
merge queue: checking #1455 on main (9903b4c) - #1473
Closed
mergify[bot] wants to merge 5 commits into
Closed
mergify[bot] wants to merge 5 commits into
mergify[bot] wants to merge 5 commits into
Conversation
Failing tests: the pane must always show the Geld, Installieren and Loeschen sentences, answer a delete question inside its row, and keep an unmatched question in the list. Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows the money one-liner while no money question is open Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::answers a delete question from its own row Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::keeps a question that matches no row in the list Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… rows Three rows sit above the question list, each with one sentence and "Keine offene Entscheidung." while empty. A question classified as money, install or delete moves into its row and is answered with the same Ask field (moved to Ask.tsx unchanged); other questions stay in the list. Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows the money one-liner while no money question is open Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::answers a delete question from its own row Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::keeps a question that matches no row in the list Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ing or unreadable Finding R1455-G1: the three lanes said "Keine offene Entscheidung." next to the loading and offline states, although nothing had been read. Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows no decision lane claiming nothing is open while the list cannot be read Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows no decision lane claiming nothing is open while the list is loading Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
While the list loads or cannot be read, the Geld, Installieren and Loeschen lanes claimed "Keine offene Entscheidung." beside the loading or offline state. They now render only when questions are open or the read finished without error (finding R1455-G1). Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows no decision lane claiming nothing is open while the list cannot be read Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows no decision lane claiming nothing is open while the list is loading Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch whispering-liaison-5d4zh9 of the
defaultqueue, to test #1455 before it merges intomain. Pushing to this branch or closing this pull request removes #1455 from the queue.What this draft tests
Mergify checks that #1455 still passes CI on top of
main. CI runs on this draft's code, built in this order:mainat9903b4c🎉 Where it stands: checks passed
CI passed on this draft.
Follow the
defaultqueue in the dashboardWhat happens next
mainand closes this draft.Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
defaultfor mergecheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergemain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge ProtectionsRequired conditions to stay in the queue
-conflict-draftbase = maincheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergelabel = review-okmain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge Protections