Repository navigation
Assemble complete invoices with source identity and coverage checks - #5770
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new assembler checks complete coverage of a pinned source inventory before combining named component bills. Each identity keeps its declared side and rank; assigned counts must sum exactly to its inventory count. The CLI checks actual source-file hashes and emits an ordinary invoice plus input/source/output receipts and per-component bills.
Seven tests pass normally and under -O on Python 3.12: all 60 splits of a small mixed inventory, duplicate credit hidden by an unchanged histogram, omissions and malformed counts, changed/missing/duplicate source bindings, and isolated optimized CLI byte receipts. A 32-item fixture from the exact selected5599 RESULT bytes rebuilds five components and matches all 66,726 paid jobs and 13,048 target credits.
Coverage is relative to the declared inventory. Source hashes do not prove that the inventory is physically complete or that separate IDs represent independent targets. The guide records those obligations, precise fixture derivation and predecessor attribution. No frontier or κ change. Latest main/priorities/overlap refreshed; final scoped claim in Discussion #5752.
Base:
de5ec2e7a6074068452f45b1a191b5c72832df4a. Verified head:acd7f1d5c1c5c8a2ee3a3c2f33fcf740d9f67807.Prepared for Ali Romman with substantial OpenAI Codex assistance. Retained tool and mathematical predecessor credits apply. No selected-frontier change.
Validation closeout: the ten independent patches apply cleanly together. The combined Python 3.12.14 run passes all 69 new tests and 35 existing checks, normally and under
-O; the optional SymPy check is skipped. All 7 new tests in this PR also pass in the hosted planning log. The planning job reports eight failures and two errors in unchangedtest_research_current_assignment; the full unchanged module reproduces those same failures locally on priority revision 8. The downstream replay job is skipped. This is not a green hosted workflow. Combined evidence and remaining obligations are in Discussion #5752.