Repository navigation
Compute exact two-fee tradeoff regions for concave invoice gains - #5762
Merged
Merged
Conversation
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new fee-region tool prices two paid fee patterns together against a complete invoice change. Exact hinge inequalities and rational polygon clipping return the full feasible tradeoff region, binding ranks, and an optional whole-fee budget with a next-count rejection witness. This can guide route/restoration choices before a full caller replay.
Six tests pass normally and under -O on Python 3.12. They compare 30 random regions to independent pairwise line intersections and 1,080 direct integer-grid tariff checks, then cover fractional vertices, zero slack, mismatched or credited fees, large counts, limits, and isolated CLI input hashes.
The guide proves sufficiency/completeness for the stated increasing-concave tariff class and explains why it is stronger than an all-power test. Physical fee completeness, source maps and κ admission remain open obligations. Current main/priorities/overlap rechecked. Coordination: Discussion #5752.
Base:
de5ec2e7a6074068452f45b1a191b5c72832df4a. Verified head:dc75e2175b09e9c270ff10ecb61075ed1411b414.Prepared for Ali Romman with substantial OpenAI Codex assistance. Retained tool and mathematical predecessor credits apply. No selected-frontier change.
Validation closeout: the ten independent patches apply cleanly together. The combined Python 3.12.14 run passes all 69 new tests and 35 existing checks, normally and under
-O; the optional SymPy check is skipped. All 6 new tests in this PR also pass in the hosted planning log. The planning job reports eight failures and two errors in unchangedtest_research_current_assignment; the full unchanged module reproduces those same failures locally on priority revision 8. The downstream replay job is skipped. This is not a green hosted workflow. Combined evidence and remaining obligations are in Discussion #5752.