Repository navigation
test: make the CP1252 overlap regression self-contained - #1702
Merged
Mister-Meeseeks merged 1 commit intoOct 14, 2026
Merged
Mister-Meeseeks merged 1 commit into
Mister-Meeseeks merged 1 commit into
Conversation
Use a temporary repository with an explicit UTF-8 excerpt and a fresh offline cache path so the CP1252 regression is independent of sparse checkout contents and user cache state. Assert the fixture result and its escaped text. Prepared with OpenAI Codex assistance.
Contributor
|
Batch review at Merged to Reviewed scope: Isolate CP1252 onboarding regression from the live overlap cache and full repository using a temporary one-package fixture. Preserve production UTF-8 behavior and run combined tests with PR1623. The pinned scoped command passed; the batch ledger contains its command, input hashes, environment and log. This incorporates the research/tooling contribution and does not change the selected κ or discharge the inherited multiplication-theorem assumptions. Batch review, attribution and evidence. Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CP1252 report regression fails in a sparse checkout when neither the local research files nor the user's cache provide a kappa excerpt. It then asserts on an empty result set without exercising the encoding behavior it is intended to check.
Run the current standalone script in a temporary repository containing one UTF-8 README and use an explicit fresh offline cache path. Assert both the single result and its escaped excerpt. This makes the test independent of checkout contents and user cache state while preserving the coverage introduced by #1299. Only this test changes; no new mathematical result is claimed.
Validation on Windows / CPython 3.12.10, based on main
0b1cccf86e2f5132ed286a26ef0a681a495740ea:python -B -m unittest discover -s tests -p test_research_onboarding.py -v.backslashreplacewith strict handling in a temporary script copy producesUnicodeEncodeErrorand makes the updated test fail.git diff --checkpasses. The full test suite and mathematical replay were not run for this test-only change; hosted CI is separate.The production encoding fix and original test remain credited to #1299 and commit
e76026571dbfa7299bf474b941c9abeb5bd556b3. Prepared with substantial OpenAI Codex assistance.Scope:
verifier-engineering / portable-replay, refined to this test fixture. The submission overlap refresh completed at 2026-10-14 07:23 UTC, covering 389 open PR records and 346 Discussion body/comment/reply records; the matching discussion described the already-incorporated #1299 fix. Local research-note coverage was limited by the sparse checkout, and code diffs were not comprehensively searched.