Add support for new OpenNBS format#2
Open
underscoren wants to merge 1 commit intoCrazedProgrammer:masterfrom
Open
Add support for new OpenNBS format#2underscoren wants to merge 1 commit intoCrazedProgrammer:masterfrom
underscoren wants to merge 1 commit intoCrazedProgrammer:masterfrom
Conversation
Owner
|
Hi underscoren, thanks for writing this PR. Apologies for the late reply - I have been on a bit of a hiatus since graduating from college. There are two things that put me off from merging this PR:
If you're still interested in tackling these two points, I would definitely consider merging it. |
Author
|
Wow, I forgot I even made this PR what a blast from the past! I'm a bit limited with free time at the moment, and I haven't properly played modded minecraft for a few years, but I'll see what I can do. There's probably a new NBS format, and I'm certain there's been advancements in ComputerCraft-esque mods, and minecraft itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you still care about this neat little library, but wave-amp shows up as the first google search for "computercraft music player" so i think some people would still be interested
I added support for the new 1.12 and 1.14 instruments (guitar, xylophone, bit, pling, etc), as well as support for the new OpenNBS format since the old NBS project has been discontinued.
Only OpenNBS format v4 and v5 are supported, and if the user tries to
wave.loadTrack()a file that's using an older format, the library will throw an error (Original NBS files still load fine though). Not sure if that's the kind of behaviour you want, but it should be easy enough to change to something like return nil.Using this, I was able to get wave-amp to work in CC: Tweaked (again, because ComputerCraft has been discontinued...) on minecraft 1.16.3 without any changes, and play some songs in the new format. I haven't tested it on older versions, so I'm not sure if there are any regressions from these changes.