Pin npm 11.18.0 in Docker builds#7841
Draft
ar2rsawseen wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
npm@10install with exactnpm@11.18.0.Why
Master's Docker images use Node 20, which supports npm
11.18.0. The currentnpm@10range resolves to npm10.9.8, whose bundled dependency tree still reports known vulnerabilities, including the criticalnode-taradvisory.npm
11.18.0:^20.17.0 || >=22.9.0;tar@7.5.19andsigstore@4.1.1;Using an exact version also makes the Docker build reproducible and prevents a future npm major release from being selected unexpectedly.
Impact
The Docker images retain Node 20 while moving their package manager to the latest compatible, audited npm version.
Validation
git diff --checkdocker buildx build --checkfor all four changed Dockerfiles11.18.0onnode:iron-bookworm-slim:v20.20.211.18.0Companion release branch PR: #7840