Open
Conversation
Contributor
Author
|
Check again please @cailmdaley, I answered to all points of your PR report. Thanks! |
- canfar_monitor: "Montior" typo, try/except/else flow for bulk destroy - canfar_submit: "debut_out" dict key typo - uncompress_fits: header assignment inside if-name guard - distribute_tiles: check arg value not flag name for dry_run Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Hey Martin, thanks for the fixes! I took the liberty of pushing a few more small ones I spotted while verifying:
Let me know if I made any mistakes. Have a nice weekend! |
sfarrens
reviewed
Feb 9, 2026
Member
sfarrens
left a comment
sfarrens
left a comment
There was a problem hiding this comment.
Hey @martinkilbinger sorry for the delay. I am a bit rusty on ShapePipe 😅, so I may have missed something, but overall the proposed changes look fine. I opened a few threads to resolve some minor issues.
Contributor
Author
sfarrens
added
documentation
cailmdaley
reviewed
Feb 11, 2026
src/shapepipe/summary_run.py
Outdated
| from shapepipe.utilities import summary | ||
|
|
||
| from summary_params_pre_v2 import * | ||
| from shapepipe.utilities impot summary_params_pre_v2 as summary_params |
Contributor
There was a problem hiding this comment.
Two syntax errors here from the import * removal:
- Line 8:
impot→import - Line 20: trailing colon on
verbose = len(args) == 3:— should beverbose = len(args) == 3
Both will crash on import.
cailmdaley
reviewed
Feb 11, 2026
sfarrens
approved these changes
Feb 13, 2026
Member
|
All good from my side. Once you have the 👍 from @cailmdaley, feel free to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates job hanling on canfar to the new canfar python library system.
This comes with job submission and monitoring classes and scripts.
New tiles (P9) were added to the CFIS tile list.
Closes some old issues #669 .
Reviewer Checklist
developbranch