feat(COR-1639): surface scan git SHA in list output - #123
Conversation
Reject skip with partial-scan/output flags, case-insensitive complete status, and satisfy clippy::question_mark on CI's Rust 1.97. Co-authored-by: Cursor <cursoragent@cursor.com>
Address RUSTSEC-2026-0194/0195 (quick-xml >=0.41) and RUSTSEC-2026-0204 (crossbeam-epoch >=0.9.20). Update Fortify parser for the quick-xml 0.41 API. Co-authored-by: Cursor <cursoragent@cursor.com>
Ibrahimrahhal
left a comment
There was a problem hiding this comment.
what is the use case here? as this can be confusing --skip-if-scanned may skip scanning because the user is working tree head is already scanned but he have uncommitted changes
yes that's expected, they mentioned they want to skip the scan if the commite was already scanned in the past 24 hours, maybe for CI reruns? |
Keep --skip-if-scanned helpers/tests alongside COR-1647 fail-on malicious gates and COR-1576 wrapper/help UX updates from main. Co-authored-by: Cursor <cursoragent@cursor.com>
Not sure, still looks not complete use case to me, for example we need to know how we should handle blocking rules. if they had a pipeline that was blocked on a day it will pass the next day if they enabled this flag. (it might not be needed but we need to understand more on how they intend to use it) |
Remove the opt-in skip path and unused list filters. Retain git_sha on scan responses/list output, plus get_repo_info discover for subdirectory SHA. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Production review of the post–--skip-if-scanned surface (SHA list column + Repository::discover in get_repo_info).
Blocking concern: switching get_repo_info from open → discover changes BLAST project attribution for subdirectory CWDs while corgea list still keys off the CWD basename, so scans can land in one project and be invisible to list from the same directory. Related SHA/content mismatch called out inline.
Verified separately: ScanResponse.git_sha is additive with a missing-field default; --json will include it when present; prior skip-path review threads are obsolete after that feature was removed.
Sent by Cursor Automation: pr-flow
* COR-1641: CLI-02: Scan-Level Metadata Tagging * COR-1641: serde skip if none --------- Co-authored-by: Cursor <cursoragent@cursor.com>


Summary
git_shaonScanResponse(defaults when absent) so the CLI can show the commit SHA Doghouse stores for each scan.corgea listtable and--jsonoutput.Repository::discoverso scans started from a subdirectory still attribute correctly.Test plan
./harness checkScanResponsedeserializesgit_shaand defaults when missingget_repo_infofrom a nested subdirectorycorgea list/corgea list --jsonagainst an env that returnsgit_sha