Skip to content

claude-sdk-audit: github_pr_merged queries GitHub unauthenticated and reads any HTTP error as 'not merged' #1932

Open

Description

@ViperJuice

claude_seat_transport.github_pr_merged (phase-loop-runtime/src/phase_loop_runtime/claude_seat_transport.py:1446) calls the GitHub API without a token. It returns False on any URLError or HTTP error.

On 2026-11-08, claude-sdk-audit (base-defined, EC-CLAUDE-3) → audit-order failed on agent-harness#1931 at head 93632e9 with print: the cited PR is not merged. The cited PR, agent-harness#1775, was merged on 2026-10-21. #1931 changes only planning and spec files, and the same check passed on that branch's earlier heads. The likely cause is an unauthenticated rate-limit 403 on a shared runner. That's unconfirmed, because the log doesn't show the HTTP status.

Suggested fix:

  1. Pass the workflow's GITHUB_TOKEN to the step and send it as Authorization.
  2. Tell 'not merged' apart from 'lookup failed': report an HTTP or network error as an unavailable or retryable audit result, not as an ordering failure, and log the status code.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions