Skip to content

closeout audit follow-ups from agent-harness#1189 landing: scope on non-closing routes, route tests, one phase resolver #1231

Open

Description

@ViperJuice

Follow-ups from the review-board president when agent-harness#1189 (closeout provenance; the audit's phase identity is an explicit --phase only) landed at 0a38ef5 (merge 9135190). None of them blocked the landing.

  • Scope the audit section on routes that don't close a phase. Claude roadmap, plan and maintain-skills prompts now carry the "Closeout audit" section, because their skill pack includes execute-phase. A planner that follows it in a repo with a declaration rebuilds declared producers for no reason. Either add the section only when the action closes out a phase, or prefix it with "only if this run closes out a phase". Main already shipped claude-execute-phase in that pack, with a phase-less audit command.
  • Test coverage. Parametrize the lane routes in test_every_prompt_route_that_can_audit_names_its_phase over every work-unit kind (lane_review, phase_reducer, phase_verify), and add grok to the enumerated harnesses.
  • One phase resolver. verification_evidence._phase_alias still reads the environment first. Align it with the explicit-only identity, so that verification.json and the producer record cannot name different phases.
  • Handoff narrowing. Keep the disclosed narrowing (a repo that custom-ignores only .dev-skills/handoffs/) noted against agent-harness#1084.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions