Skip to content

Fix MSVC build#1597

Closed
td202 wants to merge 9 commits intorelease/p11from
fix-msvc-link
Closed

Fix MSVC build#1597
td202 wants to merge 9 commits intorelease/p11from
fix-msvc-link

Conversation

@td202
Copy link
Copy Markdown
Collaborator

@td202 td202 commented Mar 20, 2026

Purpose

Generate import library for linking consensus when using MSVC.

Changes

  • Generate concordium-consensus.lib using lib.exe in the build script.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.61%. Comparing base (aa945b6) to head (c5193fc).
⚠️ Report is 64 commits behind head on release/p11.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/p11    #1597      +/-   ##
===============================================
- Coverage        62.98%   62.61%   -0.38%     
===============================================
  Files              343      319      -24     
  Lines            68253    66056    -2197     
  Branches          3013     3013              
===============================================
- Hits             42992    41363    -1629     
+ Misses           22248    21680     -568     
  Partials          3013     3013              

see 28 files with indirect coverage changes

Base automatically changed from fixrelease to release/p11 March 26, 2026 06:46
@limemloh
Copy link
Copy Markdown
Contributor

limemloh commented Apr 7, 2026

Is this still relevant @td202 ?

@td202
Copy link
Copy Markdown
Collaborator Author

td202 commented Apr 16, 2026

I think we're keeping with the gnu toolchain, so I will close this.

@td202 td202 closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants