Closed
Conversation
…of windows-gnu platform target
limemloh
approved these changes
Mar 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/p11 #1597 +/- ##
===============================================
- Coverage 62.98% 62.61% -0.38%
===============================================
Files 343 319 -24
Lines 68253 66056 -2197
Branches 3013 3013
===============================================
- Hits 42992 41363 -1629
+ Misses 22248 21680 -568
Partials 3013 3013 |
Contributor
|
Is this still relevant @td202 ? |
Collaborator
Author
|
I think we're keeping with the gnu toolchain, so I will close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Generate import library for linking consensus when using MSVC.
Changes
concordium-consensus.libusinglib.exein the build script.Checklist
hard-to-understand areas.