Repository navigation
Conversation
Debian 12 ships /etc/login.defs with ENCRYPT_METHOD SHA512, and the CIS control note says the rule allows either SHA512 or YESCRYPT, but the control selected var_password_hashing_algorithm=yescrypt, so a default system failed 5.4.1.4. Add a cis_debian12 selector (YESCRYPT|SHA512) like cis_debian13 and the Ubuntu benchmarks use, and drop the now redundant note. Fixes #15151
|
Hi @cristianchiriac. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jan-cerny
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
cis_debian12: YESCRYPT|SHA512option tovar_password_hashing_algorithm.controls/cis_debian12.yml, and drop the note "Rule allows either SHA512 or YESCRYPT", which the selector now implements.Rationale:
The Debian 12 CIS control 5.4.1.4 note says SHA512 or YESCRYPT is acceptable, but the control selected
var_password_hashing_algorithm=yescrypt(YESCRYPTonly). Debian 12'sloginpackage ships/etc/login.defswithENCRYPT_METHOD SHA512, so a default system fails 5.4.1.4.This follows exactly what Debian13 20260702 #14851 did for Debian 13 (
cis_debian13: YESCRYPT|SHA512). Ubuntu 22.04/24.04 useSHA512|YESCRYPTin the same way.Fixes Debian 12 CIS 5.4.1.4: set_password_hashing_algorithm_logindefs fails ENCRYPT_METHOD SHA512, although the control allows SHA512 or YESCRYPT #15151
Review Hints:
ENCRYPT_METHODvalue against the variable, soYESCRYPT|SHA512accepts both. The bash remediation already takes the first|-separated value, so it still setsYESCRYPT, unchanged from before.controls/cis_debian12.ymlloads withssg.controls.Policyand that 5.4.1.4 now resolves tovar_password_hashing_algorithm: cis_debian12.tests/unit/ssg-module/test_variables.pypasses.default_multivalue*.shscenarios cover multi-value selectors.