Gpu trunk prepatory cmake#3
Merged
Merged
Conversation
|
Can I test this patch? |
Contributor
|
test this please |
Contributor
|
I removed the reference to our group directory in summit.cmake, as all the necessary packages should now be available. |
Contributor
Author
|
Someone from a non ORNL site should approve and then we’ll merge |
TODO: shell program to prevent directory tree mistakes building PR's
Contributor
|
test this please |
ubulling
approved these changes
Aug 17, 2018
ubulling
left a comment
ubulling
left a comment
Contributor
There was a problem hiding this comment.
Ready to be merged if tests pass.
Contributor
|
retest this please |
PDoakORNL
pushed a commit
that referenced
this pull request
Jun 5, 2026
A DCA++ executable is compiled for one model and reads one "*-model"
section. Previously a typo'd or missing model section was silently
ignored: ModelParameters::readWrite swallows the missing-group exception
and the run proceeds on default model parameters.
Detect this at parse time, while the parsed tree is still live:
* Instrument the JSON reader to track which top-level groups were
read.
JSONObject gains a mutable accessed_ flag (set on successful
getGroup); JSONGroup::childGroupAccess() / JSONReader::
topLevelGroupAccess() report {name, accessed} as ChildGroupStatus.
getGroup also switched from operator[] to find(), so a lookup miss
no
longer inserts a null entry.
* Add checkModelSections (model_section_check.hpp), a standalone
helper
invoked from readInput for the JSON path. It reacts to three cases:
- typo / wrong file (model section present, none read) -> throw
std::invalid_argument;
- multi-model file (built model read, others present) -> warn;
- no model section at all -> warn, so model-agnostic uses of
Parameters keep working.
The check is compile-time guarded to JSONReader, since the HDF5
reader does not implement a model-section input guard (justified,
since HDF5 input is, presumably, machine-generated.
Tests: reader-level access tracking in json_reader_test, and unit
coverage of all checkModelSections branches in a new
model_section_check_test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This collects a number of minor changes to the cmake build, supporting later work.