Rating view#1706
Closed
Eel2000 wants to merge 11 commits into
Closed
Conversation
Eel2000
requested review from
TheCodeTraveler and
pictos
and removed request for
pictos
pictos
reviewed
Feb 23, 2024
pictos
left a comment
pictos
left a comment
Member
There was a problem hiding this comment.
Thanks for moving this forward, some code style points
TheCodeTraveler
requested changes
Feb 23, 2024
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @Eel2000! Could you fix these Find + Replace typos?
Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
TheCodeTraveler
requested changes
Feb 24, 2024
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @Eel2000!
We should be using read-only properties instead of expression-bodied properties.
I also noted that we still need to add descriptive XML comments, but we should wait to complete these until the Proposal has been approved.
VladislavAntonyuk
requested changes
Feb 24, 2024
|
|
||
|
|
||
| /// <summary>Star Color Bindable property.</summary> | ||
| public static readonly BindableProperty FilledBackgroundColorProperty = BindableProperty.Create(nameof(FilledBackgroundColor), typeof(Color), typeof(RatingView), defaultValue: Colors.Yellow, propertyChanged: OnBindablePropertyChanged); |
Contributor
There was a problem hiding this comment.
What is preferable Backgroud as Brush or BackgroundColor as Color?
Background allows more customization like gradient background
Author
|
@dotnet-policy-service agree
@dotnet-policy-service agree |
dotnet-policy-service
Bot
added
stale
Collaborator
|
Closing this PR in favor of the new RatingView PR: #2191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adding the Rating view to the community toolkit, this is the initial code which requires some validations.
this code was ported from an existing repo with changes made based on suggestions from the team. It needs some validations(suggestions) before going any further. Unit tests, samples, and the code doc consolidation are not yet. Will be added after reviews and any new suggestion.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)Unit tests omitted because i wanted to validate first the existing code which was ported from an existing repo before writing
unit tests.
Need some code validation before adding the sample page in the samples app.
mainat time of PRAdditional information