Open
Conversation
- add missing ADMIN_JWT_ENV and SIGNER_TLS_CERTIFICATES_PATH_ENV - support https healthchecks
…eserialization error message
…which conflicted with deserializing `SignConsensusRequest`
…fault to readlock
…mev_boost and pbs/routes separate for now)
… consolidated mev_boost module into routes module. Also stop using hardcoded ports to prevent clashing
- add missing ADMIN_JWT_ENV and SIGNER_TLS_CERTIFICATES_PATH_ENV - support https healthchecks
…eserialization error message
…which conflicted with deserializing `SignConsensusRequest`
…fault to readlock
…nly be used if modules are present
…builder-api-trait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify codebase by removing the
BuilderApiandBuilderApiStatetraits. These were in place for developers to override PBS behavior but only the default implementation was never used. Removing this abstraction allows for themev_boostmodule to be consolidated with theroutesmodule helping readability/maintainability.Also, the PBS service previously needed optional access to the signer service in the case that a custom PBS service needed signatures. This can be removed now as the canonical PBS service implementation does not need access to validator keys. Downstream this helps simplify configs and can allow the Signer service logic to be more easily decoupled and used as a library which helps module developers.
Closes #441