fix: add root favicon.ico for Google Search - #1356
Merged
Merged
Conversation
Google looks for /favicon.ico; docs only had SVG and returned 404 at that path. Use the same ICO as comfy.org.
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Deleted the logo.ico file as it is no longer needed in the project.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe documentation configuration changes the favicon path from ChangesFavicon path configuration
Suggested reviewers: 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
favicon.icoat the docs repo root (same file as comfy.org) sohttps://docs.comfy.org/favicon.icois crawlabledocs.jsonfaviconfrom/favicon.svgto/favicon.icoMintlify was only exposing generated icons under
/mintlify-assets/..., while/favicon.icoreturned 404. That is a common reason Google Search results show no site icon.Test plan
curl -sI https://docs.comfy.org/favicon.icoreturns 200 withimage/vnd.microsoft.icon(or similar)