Skip to content

fix: add root favicon.ico for Google Search - #1356

Merged
comfyui-wiki merged 2 commits into
mainfrom
fix/docs-favicon-ico
Aug 6, 2026
Merged

fix: add root favicon.ico for Google Search#1356
comfyui-wiki merged 2 commits into
mainfrom
fix/docs-favicon-ico

Conversation

@comfyui-wiki

Copy link
Copy Markdown
Member

Summary

  • Add favicon.ico at the docs repo root (same file as comfy.org) so https://docs.comfy.org/favicon.ico is crawlable
  • Point docs.json favicon from /favicon.svg to /favicon.ico

Mintlify was only exposing generated icons under /mintlify-assets/..., while /favicon.ico returned 404. That is a common reason Google Search results show no site icon.

Test plan

  • After deploy, curl -sI https://docs.comfy.org/favicon.ico returns 200 with image/vnd.microsoft.icon (or similar)
  • Browser tab still shows the Comfy icon on docs.comfy.org
  • Optionally request re-crawl in Google Search Console (icon updates can take days)

Google looks for /favicon.ico; docs only had SVG and returned 404 at that path. Use the same ICO as comfy.org.
@mintlify

mintlify Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
comfy 🟢 Ready View Preview Aug 6, 2026, 4:09 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

Deleted the logo.ico file as it is no longer needed in the project.
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1ab2a7c7-24e0-4129-beb8-c89bb5b0fd6b

📥 Commits

Reviewing files that changed from the base of the PR and between 53ce0e2 and 8eb9a75.

⛔ Files ignored due to path filters (2)
  • favicon.ico is excluded by !**/*.ico
  • logo.ico is excluded by !**/*.ico
📒 Files selected for processing (1)
  • docs.json

📝 Walkthrough

Walkthrough

The documentation configuration changes the favicon path from /favicon.svg to /favicon.ico.

Changes

Favicon path configuration

Layer / File(s) Summary
Update favicon reference
docs.json
The favicon path changes from /favicon.svg to /favicon.ico. A tiny icon switch, with no tricks in the mix.

Suggested reviewers: lin-bot23, mattmillerai, wei-hai

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docs-favicon-ico
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/docs-favicon-ico

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@comfyui-wiki
comfyui-wiki merged commit 2943e37 into main Aug 6, 2026
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant