Skip to content

feat(analytics): add --fast flag for daily incremental fetches - #1278

Merged
comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:feat/analytics-fast-mode
Jul 16, 2026
Merged

feat(analytics): add --fast flag for daily incremental fetches#1278
comfyui-wiki merged 1 commit into
Comfy-Org:mainfrom
lin-bot23:feat/analytics-fast-mode

Conversation

@lin-bot23

Copy link
Copy Markdown
Contributor

Summary

The analytics fetch script defaults to 36s page delay (Mintlify 100 req/h org limit), which is appropriate for full multi-chunk fetches but too slow for daily cron incremental runs. A 2-day incremental fetch with this delay can take 2-3 minutes for just 1-2 pages.

Changes

  • .github/scripts/analytics/fetch-assistant-insights.ts: add --fast flag that sets pageDelayMs=5000 and pageLimit=100 for quick daily incremental fetches. This is safe for small windows (1-2 pages, ~10s total delay) while still respecting the 100 req/h limit over longer periods.

Usage in daily cron

pnpm analytics:fetch --assistant-only --days 2 --fast

Checklist

  • English only (translations separate)
  • PR created by Hermes Agent (bot), do not merge

@comfyui-wiki
comfyui-wiki merged commit ddcc271 into Comfy-Org:main Jul 16, 2026
3 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cd258d97-8a84-4221-9b5a-da981550bf33

📥 Commits

Reviewing files that changed from the base of the PR and between e0e0649 and fe76b33.

📒 Files selected for processing (1)
  • .github/scripts/analytics/fetch-assistant-insights.ts

📝 Walkthrough

Walkthrough

The analytics CLI now accepts --fast, setting a 5,000 ms page delay and a 100-item page limit while overriding other paging arguments.

Changes

Analytics CLI pagination

Layer / File(s) Summary
Fast paging mode
.github/scripts/analytics/fetch-assistant-insights.ts
parseArgs recognizes --fast and forces pageDelayMs to 5_000 and pageLimit to 100, overriding other paging values. A speedy little switch.

Possibly related PRs

  • Comfy-Org/docs#1222: Introduces the analytics fetch script’s pagination and throttling controls extended by this change.

Suggested reviewers: comfyui-wiki

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from comfyui-wiki July 16, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants