Update favicon to square brand icon - #1234
Merged
Merged
Conversation
Add a dedicated favicon.svg (full-bleed ink square with the yellow C) and point the docs.json favicon field at it instead of /logo.svg. A square source lets each platform apply its own corner mask. logo.svg is left in place; nothing else references it. Part of the org-wide favicon standardization (FE-705).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesFavicon Configuration Update
Compact Metadata
No sequence diagram needed here — this ico-nic change is too svelte for a flowchart, just a tiny SVG-swap, no need to gawk! 🧚♂️ 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point the docs favicon at the square, full-bleed brand mark (ink background, yellow C), matching the org-wide standardization. A square source lets each platform apply its own corner mask instead of double-rounding a pre-rounded asset.
Changes:
favicon.svg(the square ink mark).docs.jsonfaviconfrom/logo.svgto/favicon.svg./logo.svg(the old rounded yellow icon) was referenced only by the favicon field, so nothing else is affected. The navbar and homepage wordmarks (logo/light.svg,logo/dark.svg) are separate and unchanged. Mintlify generates the favicon size/format variants from this single SVG at build.Part of the org-wide favicon standardization (FE-705); design direction (square, not rounded) confirmed by Bert. Companion PRs update the main website, workflows hub, and registry.