Call calculator - #36
Merged
Merged
Conversation
ColdIV
approved these changes
May 27, 2020
ColdIV
left a comment
ColdIV
left a comment
Owner
There was a problem hiding this comment.
(GUI)
When I enter many numbers the border around the output will disappear.
The last 2 numbers will overlap the border.
(Error output) I do not receive any error messages. (For rubbish input like abcd or for math errors like 5/0) Maybe we should add an extra window for displaying errors?
Those errors are GUI related, so feel free to merge this PR.
I will add an issue for those new problems and assign you.
| // helper variables | ||
| int textW = xEnd - xStart; | ||
| int textH = yEnd - yStart; | ||
| int lineHeight = fontSize * 1.4; // determine space between lines |
Owner
There was a problem hiding this comment.
We could put stuff like this in a config file so that we can modify the graphics by fiddling with the config instead of roaming through the source... (Same would go for colors and so on)
But I would consider that an improvement for later (probably never?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This calls the Backend Calculator with the text that the user enters and displays the current Memory.