Skip to content

update org description, remove client section, fix partner images#4

Closed
citizendrummer wants to merge 1 commit intomasterfrom
new-description
Closed

update org description, remove client section, fix partner images#4
citizendrummer wants to merge 1 commit intomasterfrom
new-description

Conversation

@citizendrummer
Copy link
Contributor

@citizendrummer citizendrummer commented Jan 20, 2018

  • update organization description

  • remove client section

  • fix partner image styles

  • remove sitecake files and markup

https://preview.c9users.io/citizendrummer/cs-new-mission/index.html

@citizendrummer
Copy link
Contributor Author

@arelia @DerekTownsend @briberri could someone review these changes then merge? Thanks!

@arelia
Copy link
Contributor

arelia commented Jan 21, 2018

@citizendrummer good job with the clean up. For future pull requests, it might be easier to review if you break the changes up into separate commits or even separate PRs. That way, if anything breaks it's easier to determine which change caused bugs. It would be easier to review and approve the Sitecake changes because the PR would only include sitecake/ files and .sc- classes

@arelia
Copy link
Contributor

arelia commented Jan 21, 2018

@citizendrummer Also, include a link to a test site so that we can see how the changes will affect the site, like @jabari-austin did here: #3

@@ -8,13 +8,10 @@
}

.img-partners {
display:inline-block;
margin:25px;
display: block;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the type of change I'd want to see on a test site first, will you please add one?

@citizendrummer
Copy link
Contributor Author

Thanks @arelia. I updated the PR with link to test site.

Do you want me to redo all the changes separately?

@citizendrummer citizendrummer deleted the new-description branch January 31, 2018 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants