Skip to content

Update transposition pitches not only on score change#957

Merged
Danielku15 merged 1 commit into
developfrom
feature/on-the-fly-transposition
Aug 27, 2022
Merged

Update transposition pitches not only on score change#957
Danielku15 merged 1 commit into
developfrom
feature/on-the-fly-transposition

Conversation

@Danielku15
Copy link
Copy Markdown
Member

Issues

Fixes #896

Proposed changes

Ensures the transposition pitches are applied to the score not only when the score changes but also when settings are updated and new renderings are initiated. This allows more of an on-the-fly transposition.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Aug 27, 2022
@Danielku15 Danielku15 merged commit 6fa4f3e into develop Aug 27, 2022
@Danielku15 Danielku15 deleted the feature/on-the-fly-transposition branch August 27, 2022 20:46
ChiHoc pushed a commit to ChiHoc/alphaTab that referenced this pull request Nov 7, 2022
@ljfreelancer88
Copy link
Copy Markdown

Hi! When this feature will be available? Thank you in advance. The tablature is transposing, but not the "audio" itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transpositionPitches doesn't work on the fly (dynamically)

2 participants