Add minor keys#880
Merged
Merged
Conversation
Danielku15
requested changes
May 28, 2022
Member
Danielku15
left a comment
Danielku15
left a comment
There was a problem hiding this comment.
Can you please add new unit tests for such kind of extensions?
Member
|
@jonaro00 C#/Kotlin builds are broken by this change. |
Contributor
Author
|
I think I managed to (poorly) implement toThrowError in C#. Kotlin is a bit trickier. Would appreciate help on that one. |
Member
|
Adapted the missing bits on the C# and Kotlin code to make them happy on your new |
ChiHoc
pushed a commit
to ChiHoc/alphaTab
that referenced
this pull request
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #875
Proposed changes
Adds the ability to specify minor keys in alphaTab. Major keys can also be explicitly stated.
Checklist
Further details