AlphaTexImporter corrections and simplifications#852
Merged
Conversation
Danielku15
requested changes
May 28, 2022
Member
Danielku15
left a comment
There was a problem hiding this comment.
Various code changes are only working in the JavaScript work but make the C# and Kotlin compilation fail.
Contributor
Author
|
Turns out I don't have the correct dotnet SDK on my machine to verify... I made my best guess at what the breaking change was, so try running workflows again. If issues remain I'll have to fix my setup and make it work on my end before pushing. |
Member
|
I converted this PR to a draft until your work is done. Please mark it as ready then 😉 |
Contributor
Author
|
It should be working at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed some things I found in AlphaTexImporter.
List of changes
MalFormed AlphaTex: @22: Error on block keysignature, expected a String found a MetaCommand: 'null'MalFormed AlphaTex: @22: Error on block keysignature, expected a String found a MetaCommand: 'ro'parseKeySignaturereference theKeySignatureenum instead of literals.KeySignature.CSharp.rctag. Typing a large number on this tag in the playground made the browser freeze and run out of memory due to the size of the midi generated. I hope it was OK to include this, I understand if you don't want to introduce hidden limits though. Maybe this could be discussed in a different issue.Checklist
Further details