Skip to content

Rework looping logic#420

Merged
Danielku15 merged 3 commits into
developfrom
feature/smooth-loop
Oct 30, 2020
Merged

Rework looping logic#420
Danielku15 merged 3 commits into
developfrom
feature/smooth-loop

Conversation

@Danielku15
Copy link
Copy Markdown
Member

Resolves #410

  • Moved looping and finish logic to time update handler
  • Moved microbuffer looping from synth to higher level
  • Ensure break on synth when end is reached.

- Moved looping and finish logic to time update handler
- Moved microbuffer looping from synth to higher level
- Ensure break on synth when end is reached.
@Danielku15 Danielku15 self-assigned this Oct 24, 2020
@Danielku15 Danielku15 marked this pull request as ready for review October 30, 2020 14:06
@Danielku15 Danielku15 merged commit d666fea into develop Oct 30, 2020
@Danielku15 Danielku15 deleted the feature/smooth-loop branch October 30, 2020 14:06
jordanske pushed a commit to jordanske/alphaTab that referenced this pull request Nov 18, 2020
* Rework looping logic

- Moved looping and finish logic to time update handler
- Moved microbuffer looping from synth to higher level
- Ensure break on synth when end is reached.

* A bit cleanup

* Ensure last note is fully played.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Looping is not seamless

1 participant