Skip to content

fix: Start and end times have to be relative to the masterbar not absolute#1393

Merged
Danielku15 merged 1 commit into
developfrom
feature/double-grace
Mar 2, 2024
Merged

fix: Start and end times have to be relative to the masterbar not absolute#1393
Danielku15 merged 1 commit into
developfrom
feature/double-grace

Conversation

@Danielku15
Copy link
Copy Markdown
Member

Issues

Fixes #1355

Proposed changes

  1. The start and end times of grace notes stealing from the previous bar were wrongly using absolute times. This caused problems on grace notes which were at any bar higher than 1 that the durations of the notes were treated wrong.
  2. The duration of the grace note was considered wrong in case of multiple grace notes. We wrongly used the remaining time of the bar instead of the actual duration.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Mar 2, 2024
@Danielku15 Danielku15 merged commit 8e0b780 into develop Mar 2, 2024
@Danielku15 Danielku15 deleted the feature/double-grace branch March 2, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When the beginning of a bar is two connected grace notes, the playback cursor gets stuck and cannot move forward normally.

1 participant