Fix: allow the import of gpx files that use displayScale as Float xml node#1243
Merged
Conversation
… node instead Double
Fix the import of some gpx files that uses <Float>instead <Double> node on XProperties
Example
```xml
<Bar id="29">
<Clef>G2</Clef>
<Voices>26 -1 -1 -1</Voices>
<XProperties>
<XProperty id="1124139520">
<Float>1.07818</Float>
</XProperty>
</XProperties>
</Bar>
```
Member
|
Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the import of some gpx files that uses Float instead Double node on XProperties
Example of gpx xml part that was throwing error
Issues
I was trying to import a gpx file with an error, tracing the error I found that was due to a child node from XProperties that the importer only looks for the Double node, but I found out in gpx that it can also be Float
Proposed changes
Look for both nodes types (Double and Float) to get the bar scale value
Checklist
Further details