Skip to content

Fix and cleanup Publish workflow#1113

Merged
Danielku15 merged 1 commit into
CoderLine:developfrom
jonaro00:fix/publish
Feb 25, 2023
Merged

Fix and cleanup Publish workflow#1113
Danielku15 merged 1 commit into
CoderLine:developfrom
jonaro00:fix/publish

Conversation

@jonaro00
Copy link
Copy Markdown
Contributor

@jonaro00 jonaro00 commented Feb 10, 2023

Issues

Fixes #1112

Proof of concept: https://github.com/jonaro00/alphaTab/actions/workflows/fixed_publish.yml

(Run # 8 is a cache miss, therefore the two publish jobs get run. Run # 9 is a cache hit, so both publish jobs are skipped.)

Proposed changes

  • Fixed caching
  • Fixed DRY
  • Adjusted schedule to 10 minutes past midnight to reduce load
  • Bumped setup-java to v3 (I have no idea if this breaks something)

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15
Copy link
Copy Markdown
Member

Thanks a lot for the change. Didn't really find the time myself to improve the workflows.

@Danielku15 Danielku15 enabled auto-merge (squash) February 25, 2023 12:10
@Danielku15 Danielku15 merged commit 6acfb2c into CoderLine:develop Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GHA publish workflow

2 participants