Skip to content

AlphaTex Error improvements. Line/col numbers.#1059

Merged
Danielku15 merged 5 commits into
CoderLine:developfrom
jonaro00:feature/linenumbers
Jan 14, 2023
Merged

AlphaTex Error improvements. Line/col numbers.#1059
Danielku15 merged 5 commits into
CoderLine:developfrom
jonaro00:feature/linenumbers

Conversation

@jonaro00
Copy link
Copy Markdown
Contributor

@jonaro00 jonaro00 commented Nov 27, 2022

Issues

  • Implements Add line and column number to AlphaTab errors #1044
  • Adds more details and logic to display better error messages overall:
    • Add a specific error for when a string is opened but never closed before EOF.
    • Only show incorrect values of _syData when it makes sense.
    • lastValidSpot makes sure the error message points out where the incorrect syntax started instead of where the importer discovered the error.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@jonaro00 jonaro00 force-pushed the feature/linenumbers branch from 46e3b36 to 63dec75 Compare November 27, 2022 04:49
@jonaro00 jonaro00 force-pushed the feature/linenumbers branch from 829b428 to 16c03b7 Compare December 18, 2022 00:32
@jonaro00
Copy link
Copy Markdown
Contributor Author

All 3 builds passing now :)

@Danielku15 Danielku15 merged commit 9bc9c57 into CoderLine:develop Jan 14, 2023
@Danielku15
Copy link
Copy Markdown
Member

Thanks for the addition 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants