Validated Neve license plans correctly - #506
Merged
Merged
Conversation
pirate-bot
added
the
pr-checklist-complete
Collaborator
There was a problem hiding this comment.
Pull request overview
Validates Templates Cloud entitlement before license activation, preventing ineligible Neve plans from appearing verified.
Changes:
- Centralizes license and tier validation.
- Applies entitlement checks during activation and access selection.
- Adds E2E coverage for Personal and Agency plans.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
shared/utils.js |
Adds shared license validation helpers. |
onboarding/src/store/selectors.js |
Uses centralized tier validation. |
assets/src/store/selectors.js |
Uses centralized tier validation. |
assets/src/Components/License.js |
Rejects ineligible licenses during activation. |
assets/src/Components/CloudLibrary/common.js |
Adds the validated license-check flow. |
assets/src/Components/Header.js |
Removes unused license plumbing. |
e2e-tests/config/mocks.js |
Adds eligible and ineligible license fixtures. |
e2e-tests/specs/license.spec.js |
Tests Personal rejection and Agency activation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
selul
requested changes
Jul 31, 2026
selul
left a comment
selul
left a comment
Contributor
There was a problem hiding this comment.
The false-verified state is gone, but the ineligible-plan case still ends up without a status.
selul
approved these changes
Aug 3, 2026
selul
approved these changes
Aug 4, 2026
Soare-Robert-Daniel
approved these changes
Aug 4, 2026
Collaborator
|
🎉 This PR is included in version 1.4.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate the license tier before activating the license. If the license is valid but the plan does not include Templates Cloud, show a notice that the license cannot be activated.
Check before Pull Request is ready:
Closes #501