FIX: driver compatibility with mongoDB 6.0+#17
Closed
Synida wants to merge 2 commits intoCodeception:masterfrom
Closed
FIX: driver compatibility with mongoDB 6.0+#17Synida wants to merge 2 commits intoCodeception:masterfrom
Synida wants to merge 2 commits intoCodeception:masterfrom
Conversation
+ compatibility fix with phpunit 10+ due to codeception/codeception 5.0.8+ requirement + locking min behat/gherkin package version for dev requirement due to compatibility issues between codeception 5.0.8 and 5.2.1 + FIX: MongoDb driver is incompatible with any mongoDB versions as of 5.0, since the mongo shell script was completely removed and replaced with mongosh + NOTE: testCleanupDirty test function might be broken for a while as it wasn't changed. It expects an early cleanup not to be executed, however nothing indicates that it should change from it's default value, so shouldCleanup returns true, which initiates a cleanup.
Synida
changed the title
+ Dropping support for php 8.0 as it isn't a supported version as of 26 Nov 2023(https://www.php.net/eol.php) + Workflows tests support for currently supported php versions(8.1, 8.2, 8.3, 8.4)
Contributor
@Synida Do you see a way to fix the test? I'm not familiar with MongoDB but I could help to move this PR forward. Would you mind creating a separate PR which tries to fixes the CI first? It'd would be okay if this separate PR drops support for PHP 8.0 and probably 8.1. |
Closed
Contributor
|
#18 might supersede this PR. |
Contributor
|
Superseded by #18 @TavoNiievez This PR should be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.