feature/codeception-upgrade-to-v5#78
Merged
buresmi7 merged 1 commit intoCodeception:masterfrom Jan 20, 2023
Merged
Conversation
Author
|
I fixed the automated test in another pull request: ggiak#3 I don't know how and if I can update this pull request directly. But maybe someone else could have a look. |
buresmi7
reviewed
Jan 19, 2023
Collaborator
Collaborator
|
Should I squash this PR? this action probably remove @koehnlein as the author of part of the code, on the other hand there is 18 commits... what do you think @ggiak @koehnlein ? |
Author
|
@buresmi7 I am ok with it, though if @koehnlein wishes we can rebase interactively. |
ggiak
force-pushed
the
master
branch
3 times, most recently
from
8053d15 to
4b1e5da
Compare
Author
|
@buresmi7, @koehnlein, I rebased, left 1 commit with co-authored-by & commit hash. This should do the trick :) |
zzhelqzkov
pushed a commit
to 1FF/visualception
that referenced
this pull request
Apr 10, 2025
* [834d22b] Improve for codeception 5 and PHP 8.1 (#3) (Codeception#78) [4b5f547] feature/codeception-upgrade-to-v5 (#2) Co-authored-by: koehnlein <github@bestof1983.de> * Codeception#69 Fix licence type in composer.json (Codeception#74) * Sync fork with upstream and update dependencies - Update composer.lock to reflect new package versions and hashes. - Change PHP requirement from `>=8.0` to `^8.1` in composer.json. - Upgrade Docker base image to `phpdockerio/php:8.1-fpm`. - Modify VisualCeption.php methods to enhance exception handling and improve code readability. * Refactor method declarations by removing unnecessary line breaks for improved readability in VisualCeption module. --------- Co-authored-by: Giorgos Giakoumettis <giorgos@yiakoumettis.gr> Co-authored-by: Michal Bureš <michal.ezop@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up to https://github.com/Codeception/Codeception/blob/5.0/src/Codeception/Module.php
This is the complete Pull request to support Codeception v5
as well as some restructuring quite few things for the project to make it compatible to php8
at the same time there are some structural changes on the project to better match with the rest of the codeception modules.
Introduced folder structure as follows:
src/Codeception
Additionally this also includes:
Testing
docker-compose up --abort-on-container-exit --buildResults: