-
Notifications
You must be signed in to change notification settings - Fork 5
Pre-Process Structs instead of on-the-fly #206
Copy link
Copy link
Closed
Labels
choreSomething doesn't envolve new features and instead focuses on the devex and codebaseSomething doesn't envolve new features and instead focuses on the devex and codebaseenhancementNew feature or requestNew feature or requestneeds testingSomething needs testingSomething needs testingpriority/lowSomething is of low prioritySomething is of low priorityscale/largeThis is a large changeThis is a large change
Milestone
Description
Metadata
Metadata
Assignees
Labels
choreSomething doesn't envolve new features and instead focuses on the devex and codebaseSomething doesn't envolve new features and instead focuses on the devex and codebaseenhancementNew feature or requestNew feature or requestneeds testingSomething needs testingSomething needs testingpriority/lowSomething is of low prioritySomething is of low priorityscale/largeThis is a large changeThis is a large change
Description
Currently almost all mixed lists, like
[]stringwithaction=block|allowor custom structs like field policies (ex.:endpoints,ipfilters,fieldpolicies) are parsed on-the-fly, this means that for exampleendpointshave to be split based on prefix!intoallowedandblocked.This can be a bit expensive and often is unnecessary, since it doesn't change (apart from config reloads) this could greatly improve performance!
Solution
CUSTOM PARSERS. (well actually these are just transforms again)
This means probably some implementation of this:
Well, this is because transforms only take into account a section of the key like
urlinstead of sayapi.url,in my head it is just adding another parameter for the fullkey and done, but I know I would hit some kind of wall again.
Alternatives
Ignore the performance loss