Merged
Conversation
bertschneider
force-pushed
the
FUZZ-754_configure_eslint_rules
branch
from
d6f5c75 to
602ea7e
Compare
br-lewis
approved these changes
Jul 13, 2023
require is used in many tests and even in some hooks, and is should not be problematic.
Introduce Jest globals to not disable no-undef rule all the time.
The JavaScript interop requires to disable TypeScript checks at some places. Disable this rule for now.
As Jest fuzz functions require the data parameter, even if not used, disable the no-unused-vars check globally.
bertschneider
force-pushed
the
FUZZ-754_configure_eslint_rules
branch
from
602ea7e to
eba94c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current test files show that file specific eslint rule configurations got out of hand.
eslint rules should be configured according to the project’s needs. E.g. the ones which are normally disabled on a per file basis can safely be disabled globally.