Change Jazzer.js fuzz tests to fixed number of runs#321
Merged
0xricksanchez merged 1 commit intomainfrom Feb 20, 2023
Merged
Conversation
3b304a0 to
3ff5f73
Compare
c220da6 to
649a5c6
Compare
f39981a to
6c0099c
Compare
6c0099c to
845b194
Compare
Contributor
|
Tests in the |
cfbe537 to
5d7a265
Compare
bertschneider
approved these changes
Feb 20, 2023
b31f3db to
7c9de19
Compare
186b3cf to
082da6f
Compare
082da6f to
7391f63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to speed up CI runs by limiting the number of runs. Doesn't seem to have much of an impact (maybe 2–3 minutes shaved off for the fuzz test runner). The main waste of time happens on the Windows/macOS runner when building the native part each time. Caching builds seems to be the one factor that could be quite beneficial. I played around with this already, but couldn't make it work quite yet (FUZZ-575... branch).
Note: It's worth noting that we could reduce the number of runs to e.g. 10000 to lower the runtime even more, that said with 10k runs the fuzz test failed as they expect an error in some cases and as long as we don't fix the Windows/macOS runner it's wasted time.