Import, duplicate and delete themes#1718
Conversation
|
Will this do essentially what CodeEditApp/CodeEditSourceEditor#245 was trying to? If yes, I'll close my PR then 😅 |
|
@danielzsh Not really but we will probably need to adjust font weights in CESE in order for this to work, so we can address it all then. We really appreciate the effort, but go ahead and close it for now. |
ed69437 to
a107a34
Compare
CodeEdit/Features/Settings/Pages/ThemeSettings/Models/ThemeModel+CRUD.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/ThemeSettings/Models/ThemeModel+CRUD.swift
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/ThemeSettings/Models/ThemeModel+CRUD.swift
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/ThemeSettings/Models/ThemeModel+CRUD.swift
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/ThemeSettings/Models/ThemeModel+CRUD.swift
Outdated
Show resolved
Hide resolved
thecoolwinter
left a comment
There was a problem hiding this comment.
Looks perfect to me! Awesome work
CodeEdit/Features/Settings/Pages/ThemeSettings/ThemeSettingsThemeDetails.swift
Outdated
Show resolved
Hide resolved
thecoolwinter
left a comment
There was a problem hiding this comment.
Sorry, misclicked my approval. It still looks perfect, just one small thing.
… from within theme details in settings
…ould always be set to light
87b199e to
225521a
Compare
thecoolwinter
left a comment
There was a problem hiding this comment.
Small formatting thing and a suggestion
CodeEdit/Features/Settings/Pages/ThemeSettings/Models/ThemeModel.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/ThemeSettings/Models/ThemeModel.swift
Outdated
Show resolved
Hide resolved
CodeEdit/Features/Settings/Pages/ThemeSettings/ThemeSettingsThemeDetails.swift
Show resolved
Hide resolved
|
I did also notice there's some serious delay when updating the theme. I tracked this back to the fact that the themes are being saved every time a color is updated. We should throttle the saving action in the future, I'll make an issue for it. |
|
Updated so the theme is updated in real time as it's edited (if it's the currently selected one) and the selected theme appearance defaults to the app's current color when opening the themes tab (eg if on light mode it shows the light mode ones first). Screen.Recording.2024-06-26.at.10.03.26.AM.mov |
Description
Improves theme settings UI. Adds the ability to import, duplicate, and delete themes. Persisting changes to theme file.
Related Issues
Checklist
When file is modified externally, reload themes to reflect changes(will do later)Theme import file validation(will do later)Screenshots
Screen.Recording.2024-06-18.at.2.22.08.PM.mp4