fix: Increase/Decrease Font Size command one step behind 🐞#1403
Merged
austincondiff merged 1 commit intoCodeEditApp:mainfrom Aug 14, 2023
Conversation
Ahattalla
changed the title
austincondiff
requested review from
0xWDG,
Wouter01,
austincondiff,
bombardier200,
matthijseikelenboom and
thecoolwinter
austincondiff
approved these changes
Aug 14, 2023
Collaborator
austincondiff
left a comment
austincondiff
left a comment
There was a problem hiding this comment.
Good catch. Thanks for the contribution @Ahattalla!
Collaborator
|
@allcontributors add @Ahattalla for bug |
Contributor
|
I've put up a pull request to add @Ahattalla! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have fixed an issue that consecutive increase/decrease font size commands, and then reversing once continues in the same direction on the first execution. Subsequent times works as expected. As an example:
I have set the font size to be the one from the newValue received, as when accessing it directly from settingsFont it will get the old one.
Related Issues
Checklist
Screenshots
Screen.Recording.2023-08-13.at.7.43.05.PM.mov