Add report_type: DB column#219
Open
shreeyaadhikari wants to merge 1 commit into
Open
Conversation
shreeyaadhikari
changed the title
nourshoreibah
approved these changes
May 26, 2026
Collaborator
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Great work!
One note on testing: We would usually test something like this by running the app locally and hitting the POST endpoint. this is a simple change so I have high confidence
Vaibhav978
approved these changes
Jun 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #176
📝 Description
Summary: Add report_type to reports so each report is classified as technical or narrative.
Files changed: db_setup.sql, report-service.ts, handler.ts, openapi.yaml, db-types.d.ts.
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
db_setup.sql showing report_type line:
report-service.ts insertion & returning of report_type:
handler.ts POST response including report_type:
openapi.yaml snippet showing the enum:
🏕️ (Optional) Future Work / Notes
Run the DB migration before deploying