200 project card#207
Conversation
tsudhakar87
left a comment
tsudhakar87
left a comment
There was a problem hiding this comment.
looks solid! just some minor things I noticed when testing locally
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Echoing thillai's comments and also, thoughts on making this one component with a prop for whether it's archived or not? Or alternatively extracting out the shared portions (maybe just the top right corner Staff section)? Just want to make sure we don't have to maintain things in 2 places
Otherwise looks great!
…rchive card + rewrote tests to match this
| @@ -0,0 +1,49 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
is this file meant to still be in this PR?
tsudhakar87
left a comment
tsudhakar87
left a comment
There was a problem hiding this comment.
looks solid! just a minor nit and maybe some outdated changes
| <h5 className="!font-bold">Start Date</h5> | ||
| <p>{props.start_date}</p> | ||
| </div> | ||
| <FaArrowRight className="justify-self-center" /> |
There was a problem hiding this comment.
Very very small nit but when I looked at the page locally, the arrow looks like its shifted towards the right because of the spacing of the div for the start date
| <p>{Math.round((props.budget_used / props.total_budget) * 100)}%</p> | ||
| </div> | ||
| ) : ( | ||
| <div className="grid grid-cols-[1fr_auto_1fr] w-full items-center !gap-2 !px-2"> |
There was a problem hiding this comment.
| <div className="grid grid-cols-[1fr_auto_1fr] w-full items-center !gap-2 !px-2"> | |
| <div className="flex flex-row items-center w-full !gap-4 !px-2"> |
| <h5 className="!font-bold">Start Date</h5> | ||
| <p>{props.start_date}</p> | ||
| </div> | ||
| <FaArrowRight className="justify-self-center" /> |
There was a problem hiding this comment.
| <FaArrowRight className="justify-self-center" /> | |
| <FaArrowRight className="shrink-0" /> |
| <div style={{ display: "flex", minHeight: "100vh" }}> | ||
| <NavBar role="admin" /> | ||
| <main style={{ flex: 1, backgroundColor: "#f9fafb" }}> | ||
| <ProjectCard variant="active" name="p1" total_budget={100} budget_used={50} members={10}/> |
There was a problem hiding this comment.
is this leftover from local testing?
3 participants
ℹ️ Issue
#200
📝 Description
Created project card components for both active and archived project cards
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Provide screenshots of any new components, styling changes, or pages.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!