Adding Action Confirmations#400
Merged
Merged
Conversation
janekamata
approved these changes
Apr 9, 2026
Contributor
janekamata
left a comment
janekamata
left a comment
There was a problem hiding this comment.
Lgtm! Tested myself by going through the different popups and everything seemed to be working
prooflesben
requested changes
Apr 11, 2026
Collaborator
prooflesben
left a comment
prooflesben
left a comment
There was a problem hiding this comment.
This pr is going to be extended to fit to all state changing actions since that's what hessann said in the client meeting bc old people are old people
4 tasks
…397-dev-adding-more-action-confirmations
…397-dev-adding-more-action-confirmations
Collaborator
|
Add cost missing confirmatiopn |
Collaborator
|
edit cost missing confirmation |
Collaborator
|
would love to hear opinions on this but should saving the dashbpoard data have a confirmation? |
prooflesben
requested changes
Apr 15, 2026
Collaborator
prooflesben
left a comment
prooflesben
left a comment
There was a problem hiding this comment.
Editing and adding a cost is missing confirmation
Contributor
It's not changing anything so I don't think so |
4 tasks
prooflesben
approved these changes
Apr 17, 2026
janekamata
added a commit
that referenced
this pull request
Apr 18, 2026
commit 2f0ce91 Merge: e604a40 847520a Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com> Date: Fri Apr 17 15:38:12 2026 -0400 Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations Adding Action Confirmations commit 847520a Merge: b3be17b e604a40 Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com> Date: Thu Apr 16 21:58:52 2026 -0400 Merge branch 'main' into 397-dev-adding-more-action-confirmations commit b3be17b Author: lyannne <xu.ly@northeastern.edu> Date: Thu Apr 16 21:42:44 2026 -0400 white background commit e604a40 Merge: 5e66036 e7803ec Author: prooflesben <122566738+prooflesben@users.noreply.github.com> Date: Thu Apr 16 21:36:56 2026 -0400 Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects update user profile updates side effects commit ceaadd4 Merge: b2fabd4 5e66036 Author: Jane Kamata <38163243+janekamata@users.noreply.github.com> Date: Wed Apr 15 22:26:16 2026 -0400 Merge branch 'main' into 397-dev-adding-more-action-confirmations commit 5e66036 Merge: 8dec21b fefdad9 Author: prooflesben <122566738+prooflesben@users.noreply.github.com> Date: Wed Apr 15 18:09:59 2026 -0400 Merge pull request #429 from Code-4-Community/bug-fix-filters Fixing filters bug commit fefdad9 Author: Jane Kamata <janekamata8@gmail.com> Date: Wed Apr 15 14:15:50 2026 -0400 Fixing filters bug commit e7803ec Merge: e68bab4 8dec21b Author: prooflesben <prooflesben@gmail.com> Date: Wed Apr 15 13:26:37 2026 -0400 Merge branch 'main' into 396-dev-user-profile-updates-side-effects commit 8dec21b Merge: 6490d98 5d56537 Author: prooflesben <122566738+prooflesben@users.noreply.github.com> Date: Wed Apr 15 12:53:24 2026 -0400 Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well update delete grant so it deletes notifs too commit e68bab4 Merge: 1f208b2 10fb2cd Author: Jane Kamata <38163243+janekamata@users.noreply.github.com> Date: Mon Apr 13 13:22:05 2026 -0400 Merge branch 'main' into 396-dev-user-profile-updates-side-effects commit b2fabd4 Merge: e2779c8 10fb2cd Author: Jane Kamata <38163243+janekamata@users.noreply.github.com> Date: Mon Apr 13 13:21:20 2026 -0400 Merge branch 'main' into 397-dev-adding-more-action-confirmations commit e2779c8 Merge: 28ebeba 2202e50 Author: adityapat24 <appathak46@gmail.com> Date: Sun Apr 12 16:50:23 2026 -0400 Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations commit 28ebeba Author: adityapat24 <appathak46@gmail.com> Date: Sun Apr 12 16:43:34 2026 -0400 action confirmations for everything and adding in colors commit 3acea04 Merge: ff6e87e 08a77c8 Author: adityapat24 <appathak46@gmail.com> Date: Sun Apr 12 16:24:02 2026 -0400 Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations commit 1f208b2 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Thu Apr 9 18:31:57 2026 -0400 fixed code and tests commit 710a756 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Thu Apr 9 17:46:42 2026 -0400 update user profile updates side effects commit ff6e87e Author: adityapat24 <appathak46@gmail.com> Date: Thu Apr 9 15:15:43 2026 -0400 confirmation for needed actions commit 5d56537 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Fri Apr 3 20:17:31 2026 -0400 updated tests commit ba316f2 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Fri Apr 3 19:29:31 2026 -0400 update delete grant so it deletes notifs too
janekamata
added a commit
that referenced
this pull request
Apr 18, 2026
commit 2f0ce91 Merge: e604a40 847520a Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com> Date: Fri Apr 17 15:38:12 2026 -0400 Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations Adding Action Confirmations commit 847520a Merge: b3be17b e604a40 Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com> Date: Thu Apr 16 21:58:52 2026 -0400 Merge branch 'main' into 397-dev-adding-more-action-confirmations commit b3be17b Author: lyannne <xu.ly@northeastern.edu> Date: Thu Apr 16 21:42:44 2026 -0400 white background commit e604a40 Merge: 5e66036 e7803ec Author: prooflesben <122566738+prooflesben@users.noreply.github.com> Date: Thu Apr 16 21:36:56 2026 -0400 Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects update user profile updates side effects commit ceaadd4 Merge: b2fabd4 5e66036 Author: Jane Kamata <38163243+janekamata@users.noreply.github.com> Date: Wed Apr 15 22:26:16 2026 -0400 Merge branch 'main' into 397-dev-adding-more-action-confirmations commit 5e66036 Merge: 8dec21b fefdad9 Author: prooflesben <122566738+prooflesben@users.noreply.github.com> Date: Wed Apr 15 18:09:59 2026 -0400 Merge pull request #429 from Code-4-Community/bug-fix-filters Fixing filters bug commit fefdad9 Author: Jane Kamata <janekamata8@gmail.com> Date: Wed Apr 15 14:15:50 2026 -0400 Fixing filters bug commit e7803ec Merge: e68bab4 8dec21b Author: prooflesben <prooflesben@gmail.com> Date: Wed Apr 15 13:26:37 2026 -0400 Merge branch 'main' into 396-dev-user-profile-updates-side-effects commit 8dec21b Merge: 6490d98 5d56537 Author: prooflesben <122566738+prooflesben@users.noreply.github.com> Date: Wed Apr 15 12:53:24 2026 -0400 Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well update delete grant so it deletes notifs too commit e68bab4 Merge: 1f208b2 10fb2cd Author: Jane Kamata <38163243+janekamata@users.noreply.github.com> Date: Mon Apr 13 13:22:05 2026 -0400 Merge branch 'main' into 396-dev-user-profile-updates-side-effects commit b2fabd4 Merge: e2779c8 10fb2cd Author: Jane Kamata <38163243+janekamata@users.noreply.github.com> Date: Mon Apr 13 13:21:20 2026 -0400 Merge branch 'main' into 397-dev-adding-more-action-confirmations commit e2779c8 Merge: 28ebeba 2202e50 Author: adityapat24 <appathak46@gmail.com> Date: Sun Apr 12 16:50:23 2026 -0400 Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations commit 28ebeba Author: adityapat24 <appathak46@gmail.com> Date: Sun Apr 12 16:43:34 2026 -0400 action confirmations for everything and adding in colors commit 3acea04 Merge: ff6e87e 08a77c8 Author: adityapat24 <appathak46@gmail.com> Date: Sun Apr 12 16:24:02 2026 -0400 Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations commit 1f208b2 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Thu Apr 9 18:31:57 2026 -0400 fixed code and tests commit 710a756 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Thu Apr 9 17:46:42 2026 -0400 update user profile updates side effects commit ff6e87e Author: adityapat24 <appathak46@gmail.com> Date: Thu Apr 9 15:15:43 2026 -0400 confirmation for needed actions commit 5d56537 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Fri Apr 3 20:17:31 2026 -0400 updated tests commit ba316f2 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Fri Apr 3 19:29:31 2026 -0400 update delete grant so it deletes notifs too
janekamata
added a commit
that referenced
this pull request
Apr 18, 2026
commit 5a9c130 Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com> Date: Sat Apr 18 00:34:03 2026 -0400 changed colors and added missing confirmations (#431) * changed colors and added missing confirmations * Styling fixes * prioritize adding errors over action confirmation modal * Updating yellow --------- Co-authored-by: Jane Kamata <janekamata8@gmail.com> Co-authored-by: lyannne <xu.ly@northeastern.edu> commit 2f0ce91 Merge: e604a40 847520a Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com> Date: Fri Apr 17 15:38:12 2026 -0400 Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations Adding Action Confirmations commit 847520a Merge: b3be17b e604a40 Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com> Date: Thu Apr 16 21:58:52 2026 -0400 Merge branch 'main' into 397-dev-adding-more-action-confirmations commit b3be17b Author: lyannne <xu.ly@northeastern.edu> Date: Thu Apr 16 21:42:44 2026 -0400 white background commit e604a40 Merge: 5e66036 e7803ec Author: prooflesben <122566738+prooflesben@users.noreply.github.com> Date: Thu Apr 16 21:36:56 2026 -0400 Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects update user profile updates side effects commit ceaadd4 Merge: b2fabd4 5e66036 Author: Jane Kamata <38163243+janekamata@users.noreply.github.com> Date: Wed Apr 15 22:26:16 2026 -0400 Merge branch 'main' into 397-dev-adding-more-action-confirmations commit 5e66036 Merge: 8dec21b fefdad9 Author: prooflesben <122566738+prooflesben@users.noreply.github.com> Date: Wed Apr 15 18:09:59 2026 -0400 Merge pull request #429 from Code-4-Community/bug-fix-filters Fixing filters bug commit fefdad9 Author: Jane Kamata <janekamata8@gmail.com> Date: Wed Apr 15 14:15:50 2026 -0400 Fixing filters bug commit e7803ec Merge: e68bab4 8dec21b Author: prooflesben <prooflesben@gmail.com> Date: Wed Apr 15 13:26:37 2026 -0400 Merge branch 'main' into 396-dev-user-profile-updates-side-effects commit 8dec21b Merge: 6490d98 5d56537 Author: prooflesben <122566738+prooflesben@users.noreply.github.com> Date: Wed Apr 15 12:53:24 2026 -0400 Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well update delete grant so it deletes notifs too commit e68bab4 Merge: 1f208b2 10fb2cd Author: Jane Kamata <38163243+janekamata@users.noreply.github.com> Date: Mon Apr 13 13:22:05 2026 -0400 Merge branch 'main' into 396-dev-user-profile-updates-side-effects commit b2fabd4 Merge: e2779c8 10fb2cd Author: Jane Kamata <38163243+janekamata@users.noreply.github.com> Date: Mon Apr 13 13:21:20 2026 -0400 Merge branch 'main' into 397-dev-adding-more-action-confirmations commit e2779c8 Merge: 28ebeba 2202e50 Author: adityapat24 <appathak46@gmail.com> Date: Sun Apr 12 16:50:23 2026 -0400 Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations commit 28ebeba Author: adityapat24 <appathak46@gmail.com> Date: Sun Apr 12 16:43:34 2026 -0400 action confirmations for everything and adding in colors commit 3acea04 Merge: ff6e87e 08a77c8 Author: adityapat24 <appathak46@gmail.com> Date: Sun Apr 12 16:24:02 2026 -0400 Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations commit 1f208b2 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Thu Apr 9 18:31:57 2026 -0400 fixed code and tests commit 710a756 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Thu Apr 9 17:46:42 2026 -0400 update user profile updates side effects commit ff6e87e Author: adityapat24 <appathak46@gmail.com> Date: Thu Apr 9 15:15:43 2026 -0400 confirmation for needed actions commit 5d56537 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Fri Apr 3 20:17:31 2026 -0400 updated tests commit ba316f2 Author: Camila Carrillo <carrillo.ca@northeastern.edu> Date: Fri Apr 3 19:29:31 2026 -0400 update delete grant so it deletes notifs too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #397
📝 Description
Added the action confirmation modal based on the discussed user actions
Briefly list the changes made to the code:
✔️ Verification
What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.
Frontend Testing
