Allow cloaked units under player control to have SELECT cursor on it when about to select#20
Open
chaserli wants to merge 1 commit into
Open
Allow cloaked units under player control to have SELECT cursor on it when about to select#20chaserli wants to merge 1 commit into
chaserli wants to merge 1 commit into
Conversation
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
chaserli
marked this pull request as draft
March 10, 2024 09:48
chaserli
marked this pull request as ready for review
March 12, 2024 02:35
Member
|
@chaserli If you don't mind, I'll get back to this PR in a couple of weeks. There are a few other things I'm busy with right now |
Member
Author
Belonit
force-pushed
the
main
branch
2 times, most recently
from
March 27, 2024 11:32
b0af8ba to
dbcfd07
Compare
chaserli
force-pushed
the
fix/selectcloak
branch
from
April 5, 2024 12:55
e0f9764 to
916afee
Compare
chaserli
force-pushed
the
fix/selectcloak
branch
from
November 7, 2024 12:35
63f72f4 to
fd36e64
Compare
chaserli
force-pushed
the
fix/selectcloak
branch
from
December 17, 2024 13:25
946337e to
b97a815
Compare
Belonit
force-pushed
the
fix/selectcloak
branch
from
April 12, 2025 02:09
b97a815 to
8c1b515
Compare
Belonit
force-pushed
the
fix/selectcloak
branch
from
April 13, 2025 14:42
887ea7c to
adfdfed
Compare
chaserli
added a commit
to chaserli/CNCNet_dll
that referenced
this pull request
May 30, 2025
Starkku
pushed a commit
to Starkku/yrpp-spawner
that referenced
this pull request
Feb 22, 2026
chaserli
added a commit
that referenced
this pull request
Feb 24, 2026
chaserli
added a commit
that referenced
this pull request
Feb 24, 2026
chaserli
force-pushed
the
fix/selectcloak
branch
from
February 24, 2026 01:52
3781e02 to
e3ca580
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically at this point it's useless to do all these checks.
What had the program done?
This is the very end of that function it's not sufficient to only let "me" select
pObjectif it belongs tothis->Ownerwhich is known to be controlled by me. It is also possible that "I" (the controller ofthis) can only control the owning house ofpObjectbut is not it. In that case you gotta let me select it too