CP-43958: support per-component affinity in aggregator - #881
Merged
Conversation
evan-cz
force-pushed
the
worktree-per-component-affinity
branch
from
June 30, 2026 18:46
b430b10 to
c1d8d57
Compare
Wire aggregator.affinity into the aggregator Deployment. The value was defined in values.yaml but the template passed only defaults.affinity, so an operator setting aggregator.affinity got nothing. Every other chart-managed workload already honored its per-component affinity (server and webhook via their own values, the init/cert/backfill/config-loader jobs via the insightsController.server.affinity fallback, KSM via kubeStateMetrics.affinity); the aggregator was the one gap. Purely additive: with the default empty affinity the rendered manifests are unchanged (the tests/helm/template baselines are untouched). Add helm/tests/component_affinity_test.yaml covering per-component affinity rendering and cross-component isolation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
evan-cz
force-pushed
the
worktree-per-component-affinity
branch
from
June 30, 2026 18:59
c1d8d57 to
5499df7
Compare
evan-cz
changed the title
evan-cz
marked this pull request as ready for review
June 30, 2026 20:38
This was referenced Jun 30, 2026
evan-cz
enabled auto-merge
July 1, 2026 14:05
amfelso
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes per-component affinity configuration for the CloudZero Agent Helm chart (CP-43958). Purely additive — no default-rendered manifest changes.
The only real gap was the aggregator:
aggregator.affinityexisted invalues.yamlbut the aggregator Deployment passed onlydefaults.affinity, so a user-setaggregator.affinitywas silently ignored. This wires it in. Every other chart-managed workload already honored its per-component affinity — the server and webhook server via their own values, the init/cert/backfill/config-loader jobs via the sanctionedinsightsController.server.affinityfallback, and bundled KSM viakubeStateMetrics.affinity.affinity, rendered manifests are byte-identical to before — thetests/helm/template/baselines are unchanged.Testing
helm/tests/component_affinity_test.yaml— per-component affinity rendering + cross-component isolation (6 tests).make helm-test-unittest: full suite green.make helm-test-template-diff: clean (no baseline changes).Scope notes
helmless-jobdeliberately left ondefaults.affinityonly.values.schema.jsonchange — every affectedaffinitykey was already present and schema-valid. The per-componentaffinityvalues are already documented by their existingvalues.yamlcomments.podAntiAffinity(selectorapp: webhook-servermatches no pods).🤖 Generated with Claude Code